Date: Fri, 19 Apr 2013 08:51:37 GMT From: Thomas Mueller <tmueller@sysgo.com> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/177973: news/pan Reversed logic for GTK3 option Message-ID: <201304190851.r3J8pbK0047748@red.freebsd.org> Resent-Message-ID: <201304190900.r3J900CU081595@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 177973
>Category: ports
>Synopsis: news/pan Reversed logic for GTK3 option
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Fri Apr 19 09:00:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator: Thomas Mueller
>Release: FreeBSD 9.1-STABLE amd64
>Organization:
>Environment:
FreeBSD tmu 9.1-STABLE FreeBSD 9.1-STABLE #50: Thu Apr 18 09:58:43 CEST 2013 toor@tmu:/usr/obj/usr/src/sys/TOM amd64
>Description:
The Makefile of news/pan handles the GTK3 option with reversed logic,
if GTK3 is 'off' the port is compiled with GTK3 support.
>How-To-Repeat:
tmu:/usr/ports/news/pan# make showconfig
===> The following configuration options are available for pan-0.139_1:
GTK3=off: Use gtk+3 based UI instead of gtk+2
GTKSPELL=on: Spell checking support (gtk+2 only)
===> Use 'make config' to modify these settings
tmu:/usr/ports/news/pan# make build-depends-list
/usr/ports/accessibility/atk
/usr/ports/devel/gettext
/usr/ports/devel/glib20
[...]
/usr/ports/x11-toolkits/gtk30
>Fix:
tmu:/usr/ports/news/pan# diff -u Makefile.orig Makefile
--- Makefile.orig 2013-03-18 09:17:05.753654210 +0100
+++ Makefile 2013-04-19 10:50:08.053299421 +0200
@@ -33,7 +33,7 @@
.include <bsd.port.options.mk>
-.if ${PORT_OPTIONS:MGTK3}
+.if !${PORT_OPTIONS:MGTK3}
USE_GNOME+= gtk20
CONFIGURE_ARGS+=--without-gtk3
.else
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201304190851.r3J8pbK0047748>