From owner-svn-src-all@freebsd.org Sun Oct 18 19:51:44 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 780A143A095; Sun, 18 Oct 2020 19:51:44 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from anubis.delphij.net (anubis.delphij.net [64.62.153.212]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "anubis.delphij.net", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CDrB70ln0z4qym; Sun, 18 Oct 2020 19:51:42 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from p51.home.us.delphij.net (unknown [IPv6:2601:646:8601:f4a:e670:b8ff:fe5c:4e69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by anubis.delphij.net (Postfix) with ESMTPSA id 884DC47915; Sun, 18 Oct 2020 12:51:36 -0700 (PDT) Reply-To: d@delphij.net Subject: Re: svn commit: r366781 - in head: include lib/libc/stdlib To: Konstantin Belousov , Xin LI Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <202010170414.09H4EdBF097521@repo.freebsd.org> <20201017065326.GY2643@kib.kiev.ua> From: Xin Li Organization: The FreeBSD Project Message-ID: <592395b1-3985-5416-a06a-44335321799f@delphij.net> Date: Sun, 18 Oct 2020 12:51:35 -0700 MIME-Version: 1.0 In-Reply-To: <20201017065326.GY2643@kib.kiev.ua> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 4CDrB70ln0z4qym X-Spamd-Bar: --- X-Spamd-Result: default: False [-3.38 / 15.00]; HAS_REPLYTO(0.00)[d@delphij.net]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+mx]; RCPT_COUNT_FIVE(0.00)[5]; HAS_ORG_HEADER(0.00)[]; DKIM_TRACE(0.00)[delphij.net:+]; DMARC_POLICY_ALLOW(-0.50)[delphij.net,reject]; NEURAL_HAM_SHORT(-0.47)[-0.474]; FREEMAIL_TO(0.00)[gmail.com,freebsd.org]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:6939, ipnet:64.62.128.0/18, country:US]; MID_RHS_MATCH_FROM(0.00)[]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.93)[-0.933]; R_DKIM_ALLOW(-0.20)[delphij.net:s=m7e2]; FREEFALL_USER(0.00)[delphij]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-0.97)[-0.973]; MIME_GOOD(-0.10)[text/plain]; REPLYTO_DOM_EQ_FROM_DOM(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MAILMAN_DEST(0.00)[svn-src-all,svn-src-head] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Oct 2020 19:51:44 -0000 Hi, Thanks very much for the feedback. I have created a new change for review at https://reviews.freebsd.org/D26845 , could you please take a look and let me know if it's satisfactory? On 10/16/20 11:53 PM, Konstantin Belousov wrote: [...]>> +int ptsname_r(int, char *, size_t); > This declaration appears in the __XSI_VISIBLE block, but I do not see the > function description in the IEEE Std 1003.1™-2017 text (base issue 7). > > Review mentioned that the function is scheduled for issue 8, but shouldn't > it put under BSD_VISIBLE until specification is finalized ? Good point, fixed in the proposed change. [...] >> Modified: head/lib/libc/stdlib/Symbol.map >> ============================================================================== >> --- head/lib/libc/stdlib/Symbol.map Sat Oct 17 01:06:04 2020 (r366780) >> +++ head/lib/libc/stdlib/Symbol.map Sat Oct 17 04:14:38 2020 (r366781) >> @@ -125,6 +125,7 @@ FBSD_1.6 { >> qsort_s; >> rand; >> srand; >> + ptsname_r; > This is unsorted now. Fixed in the proposed change. [...] >> +{ >> + static char pt_slave[sizeof _PATH_DEV + SPECNAMELEN]; > We usually write sizeof(_PATH_DEV). This was from previous code so I leave it as-is, but fixed in the proposed change. >> + >> + if (ptsname_r(fildes, pt_slave, sizeof(pt_slave)) == 0) > Since ptsname_r is non-standard and exported, userspace is allowed to > interpose the symbol, which would break ptsname(). Thanks for pointing it out -- I should have paid more attention here. Fixed in the proposed change. >> + return (pt_slave); >> + else > 'else' is redundand. Removed else and used a straight return instead. Cheers,