From owner-svn-src-head@freebsd.org Sat Sep 19 16:37:55 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 59A44A0575B; Sat, 19 Sep 2015 16:37:55 +0000 (UTC) (envelope-from gnn@neville-neil.com) Received: from smtp.hungerhost.com (smtp.hungerhost.com [216.38.53.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 2FEF3137B; Sat, 19 Sep 2015 16:37:54 +0000 (UTC) (envelope-from gnn@neville-neil.com) Received: from pool-108-54-164-204.nycmny.fios.verizon.net ([108.54.164.204]:50234 helo=[192.168.1.8]) by vps2.hungerhost.com with esmtpsa (TLSv1:DHE-RSA-AES256-SHA:256) (Exim 4.85) (envelope-from ) id 1ZdL96-00037y-O6; Sat, 19 Sep 2015 12:37:52 -0400 From: "George Neville-Neil" To: "Hans Petter Selasky" Cc: "David Chisnall" , "Gleb Smirnoff" , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r287780 - in head: share/man/man9 sys/kern sys/sys Date: Sat, 19 Sep 2015 12:37:52 -0400 Message-ID: <64D8263B-1F5D-40E5-994C-479C39B69DC9@neville-neil.com> In-Reply-To: <55FD23C5.5010008@selasky.org> References: <201509141052.t8EAqRWf008293@repo.freebsd.org> <20150916220559.GS1023@FreeBSD.org> <55FA69BD.10507@selasky.org> <0952027A-5276-487D-99B8-74747B0EEF5D@FreeBSD.org> <55FD23C5.5010008@selasky.org> MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-Mailer: MailMate (1.9.2r5107) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vps2.hungerhost.com X-AntiAbuse: Original Domain - freebsd.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - neville-neil.com X-Get-Message-Sender-Via: vps2.hungerhost.com: authenticated_id: gnn@neville-neil.com X-Source: X-Source-Args: X-Source-Dir: X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 Sep 2015 16:37:55 -0000 On 19 Sep 2015, at 4:58, Hans Petter Selasky wrote: > On 09/17/15 11:07, David Chisnall wrote: >> I would expect*anyone* making a change like this to have both the >> design and code reviewed for sanity checking. > > Please add an entry to MAINTAINERS for those parts of the kernel which > require this strict reviews. > This is not about MAINTAINERS, this is about review. Several commenters on this thread have pointed out that this code, which is part of a core component of the system, was committed without review. Please back this out and then put whatever you propose to do up in the reviews.freebsd.org system. Best, George