Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 19 Sep 2015 12:37:52 -0400
From:      "George Neville-Neil" <gnn@neville-neil.com>
To:        "Hans Petter Selasky" <hps@selasky.org>
Cc:        "David Chisnall" <theraven@FreeBSD.org>, "Gleb Smirnoff" <glebius@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r287780 - in head: share/man/man9 sys/kern sys/sys
Message-ID:  <64D8263B-1F5D-40E5-994C-479C39B69DC9@neville-neil.com>
In-Reply-To: <55FD23C5.5010008@selasky.org>
References:  <201509141052.t8EAqRWf008293@repo.freebsd.org> <20150916220559.GS1023@FreeBSD.org> <55FA69BD.10507@selasky.org> <0952027A-5276-487D-99B8-74747B0EEF5D@FreeBSD.org> <55FD23C5.5010008@selasky.org>

next in thread | previous in thread | raw e-mail | index | archive | help


On 19 Sep 2015, at 4:58, Hans Petter Selasky wrote:

> On 09/17/15 11:07, David Chisnall wrote:
>> I would expect*anyone*  making a change like this to have both the 
>> design and code reviewed for sanity checking.
>
> Please add an entry to MAINTAINERS for those parts of the kernel which 
> require this strict reviews.
>

This is not about MAINTAINERS, this is about review.  Several commenters 
on this thread
have pointed out that this code, which is part of a core component of 
the system, was committed
without review.  Please back this out and then put whatever you propose 
to do up in the reviews.freebsd.org
system.

Best,
George




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?64D8263B-1F5D-40E5-994C-479C39B69DC9>