From owner-svn-src-all@FreeBSD.ORG Thu Apr 11 18:05:50 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 6DA8D3B2 for ; Thu, 11 Apr 2013 18:05:50 +0000 (UTC) (envelope-from juli@clockworksquid.com) Received: from mail-la0-x229.google.com (mail-la0-x229.google.com [IPv6:2a00:1450:4010:c03::229]) by mx1.freebsd.org (Postfix) with ESMTP id EB67AF5C for ; Thu, 11 Apr 2013 18:05:49 +0000 (UTC) Received: by mail-la0-f41.google.com with SMTP id er20so1775893lab.0 for ; Thu, 11 Apr 2013 11:05:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :x-gm-message-state; bh=RsGH/Cx0FLCOW26rAHLskklkqamDO5yZ1qwDuNHEKis=; b=Kyu7bAXuSZl9o5nLrTP07VKcs3BwoY6j0006GjGW4xkvdN0YhxBsbviWT26b61UKgT Lrg9TCWlYea3Iwl23dVuu9n9PgHSvqRiNdIZzYsDKbHEzpvGQSt+J8r4ze7E0waao/pw /qkK0+f2LHEKZgdc/rTUpzkXWGCA0IDEJWBF/LhdvJMlhMRwWXZPEPhsavolOwh92u6a pfip/FfZyMyp+0FaPnsBl3vSzqNL0E3uvEYQAebc4KCT4fxfud/ES8r6WUtufmBTtd6b 0qvO84LdxK6YTBgHowjvMrbZSzCBqkKw92bz1a73eFnLgR11FIC+9qmytgsHMGW2htsC zQ7A== X-Received: by 10.152.115.196 with SMTP id jq4mr3739654lab.53.1365703548647; Thu, 11 Apr 2013 11:05:48 -0700 (PDT) MIME-Version: 1.0 Sender: juli@clockworksquid.com Received: by 10.152.28.196 with HTTP; Thu, 11 Apr 2013 11:05:28 -0700 (PDT) In-Reply-To: <20130411180013.GB76816@FreeBSD.org> References: <201304110730.r3B7Uo6d067302@svn.freebsd.org> <20130411175308.Q1435@besplex.bde.org> <20130411082457.GS76816@FreeBSD.org> <20130411184049.W1641@besplex.bde.org> <20130411091418.GW76816@FreeBSD.org> <20130411201652.F1911@besplex.bde.org> <20130411180013.GB76816@FreeBSD.org> From: Juli Mallett Date: Thu, 11 Apr 2013 11:05:28 -0700 X-Google-Sender-Auth: wzRidOcnZ9cIwzr0ox_W3BnFq5g Message-ID: Subject: Re: svn commit: r249355 - head/lib/libkvm To: Gleb Smirnoff Content-Type: text/plain; charset=UTF-8 X-Gm-Message-State: ALoCoQkJ/RQmhb0XCsvK9g+bZkpEWApdL1uwiYtFiOkB2Ue7VeWVpp4uXwfYH7cW4BlExFVU9aIX Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Bruce Evans X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Apr 2013 18:05:50 -0000 On Thu, Apr 11, 2013 at 11:00 AM, Gleb Smirnoff wrote: > Bruce, > > On Thu, Apr 11, 2013 at 09:07:25PM +1000, Bruce Evans wrote: > B> Just routine avoidance of namespace pollution. This is easy in such a > B> simple header. > > Sorry, with all respect, but I can't call including sys/types.h > a namespace pollution. > > Ok, even you force me to name it that way, still I would prefer > namespace pollution instead of handmade copy pasted typedefs. But Gleb, making such changes unilaterally is a bit of a leap. The project has mostly accepted Bruce's wisdom about trying to minimize and reduce namespace pollution. Now, this isn't a standard header so it's quite a bit less of a concern, but it's not no concern. If you think that we should reverse our trend on including namespace-polluting headers in system headers, we should discuss that on arch@, and it shouldn't be something that's done without any discussion or consideration. Should we expect further changes of this nature (and of the proposed nature removing __size_t and __ssize_t use) if you make changes to other headers as part of your work? Are you going to add to every header currently using in a single go, or will you be doing that a little at a time when making functional changes? Thanks, Juli.