From owner-p4-projects@FreeBSD.ORG  Wed Jun 17 14:16:35 2009
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 7F02C106579E; Wed, 17 Jun 2009 14:16:35 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 845391065690
	for <perforce@freebsd.org>; Wed, 17 Jun 2009 14:16:34 +0000 (UTC)
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id 709678FC21
	for <perforce@freebsd.org>; Wed, 17 Jun 2009 14:16:34 +0000 (UTC)
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id n5HEGYpq050604
	for <perforce@freebsd.org>; Wed, 17 Jun 2009 14:16:34 GMT
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.3/8.14.3/Submit) id n5HEGY2Q050602
	for perforce@freebsd.org; Wed, 17 Jun 2009 14:16:34 GMT
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Date: Wed, 17 Jun 2009 14:16:34 GMT
Message-Id: <200906171416.n5HEGY2Q050602@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	bb+lists.freebsd.perforce@cyrus.watson.org using -f
From: Robert Watson <rwatson@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 164582 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 17 Jun 2009 14:16:36 -0000

http://perforce.freebsd.org/chv.cgi?CH=164582

Change 164582 by rwatson@rwatson_freebsd_capabilities on 2009/06/17 14:16:06

	Simplify.

Affected files ...

.. //depot/projects/trustedbsd/capabilities/src/tools/cap/fdrpc/Makefile#2 edit
.. //depot/projects/trustedbsd/capabilities/src/tools/cap/fdrpc/fdrpc.c#3 edit

Differences ...

==== //depot/projects/trustedbsd/capabilities/src/tools/cap/fdrpc/Makefile#2 (text+ko) ====


==== //depot/projects/trustedbsd/capabilities/src/tools/cap/fdrpc/fdrpc.c#3 (text+ko) ====

@@ -45,6 +45,11 @@
 #include <stdlib.h>
 #include <unistd.h>
 
+/*
+ * This test program creates a sandbox, passes it a file descriptor by RPC,
+ * and then expects it back in the reply.
+ */
+
 #define	FDRPC_SANDBOX	"./fdrpc"
 
 int
@@ -64,10 +69,7 @@
 	    &lcsp) < 0)
 		err(-1, "lch_start %s", FDRPC_SANDBOX);
 
-	/*
-	 * Send a file descriptor to the sandbox, then get it back.
-	 */
-	ch = 'X';
+	ch = 'X';		/* RPC data. */
 	fdcount = 1;
 	fd_send = STDIN_FILENO;
 	iov.iov_base = &ch;
@@ -89,7 +91,7 @@
 int
 cap_main(int argc, char *argv[])
 {
-	int fdarray[2], fdcount;
+	int fd, fdcount;
 	struct lc_host *lchp;
 	struct iovec iov;
 	uint32_t opno, seqno;
@@ -100,23 +102,24 @@
 		err(-1, "lcs_get");
 
 	while (1) {
-		fdcount = 2;
-
+		fdcount = 1;
 		if (lcs_recvrpc_rights(lchp, &opno, &seqno, &buffer, &len,
-		    fdarray, &fdcount) < 0) {
+		    &fd, &fdcount) < 0) {
 			if (errno == EPIPE)
 				exit(-1);
 			else
 				err(-1, "lcs_recvrpc_rights");
 		}
+		if (opno != 0)
+			errx(-1, "lcs_recvrpc_rights: opno %d", opno);
 		if (fdcount != 1)
 			errx(-1, "lcs_recvrpc_rights: fdcount %d", fdcount);
 		iov.iov_len = len;
 		iov.iov_base = buffer;
-		if (lcs_sendrpc_rights(lchp, opno, seqno, &iov, 1, fdarray,
+		if (lcs_sendrpc_rights(lchp, opno, seqno, &iov, 1, &fd,
 		    fdcount) < 0)
 			err(-1, "lcs_sendrpc_rights");
-		close(fdarray[0]);
+		close(fd);
 		free(buffer);
 	}
 }