From owner-freebsd-net@FreeBSD.ORG Tue Jul 3 15:27:16 2007 Return-Path: X-Original-To: freebsd-net@FreeBSD.org Delivered-To: freebsd-net@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 606DA16A41F for ; Tue, 3 Jul 2007 15:27:16 +0000 (UTC) (envelope-from fox@verio.net) Received: from dfw-smtpout1.email.verio.net (dfw-smtpout1.email.verio.net [129.250.36.41]) by mx1.freebsd.org (Postfix) with ESMTP id 1207E13C45B for ; Tue, 3 Jul 2007 15:27:15 +0000 (UTC) (envelope-from fox@verio.net) Received: from [129.250.36.63] (helo=dfw-mmp3.email.verio.net) by dfw-smtpout1.email.verio.net with esmtp id 1I5kHX-0006yk-Fw; Tue, 03 Jul 2007 15:27:11 +0000 Received: from [129.250.40.241] (helo=limbo.int.dllstx01.us.it.verio.net) by dfw-mmp3.email.verio.net with esmtp id 1I5kHX-0005iA-Az; Tue, 03 Jul 2007 15:27:11 +0000 Received: by limbo.int.dllstx01.us.it.verio.net (Postfix, from userid 1000) id 530AB8E296; Tue, 3 Jul 2007 10:27:07 -0500 (CDT) Date: Tue, 3 Jul 2007 10:27:07 -0500 From: David DeSimone To: W Forms Message-ID: <20070703152706.GA32357@verio.net> Mail-Followup-To: W Forms , freebsd-net@FreeBSD.org References: <200707031100.l63B0GV0020511@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; x-action=pgp-signed Content-Disposition: inline In-Reply-To: <200707031100.l63B0GV0020511@freefall.freebsd.org> Precedence: bulk User-Agent: Mutt/1.5.9i Cc: freebsd-net@FreeBSD.org Subject: Re: kern/112710: [re] if_re driver detects incorrect b243a405a405 MAC address on SMC9452TX-1 pci gigabit cards X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Jul 2007 15:27:16 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 W Forms wrote: > > I don't really understand this, since from what I can see all that > Pyun YongHyeon's changes do is replacing a constant value of 6 and 8 > with macros containing the value of 6 and 8. Here's the patch as I recall it: - sc->rl_eewidth = 6; + sc->rl_eewidth = RL_9356_ADDR_LEN; re_read_eeprom(sc, (caddr_t)&re_did, 0, 1); if (re_did != 0x8129) - sc->rl_eewidth = 8; + sc->rl_eewidth = RL_9346_ADDR_LEN; /* 9346 EEPROM commands */ +#define RL_9346_ADDR_LEN 6 /* 93C46 1K: 128x16 */ +#define RL_9356_ADDR_LEN 8 /* 93C56 2K: 256x16 */ It looks to me like 6 was replaced with 8, and vice versa. In other words, a real bug fix. :) - -- David DeSimone == Network Admin == fox@verio.net "It took me fifteen years to discover that I had no talent for writing, but I couldn't give it up because by that time I was too famous. -- Robert Benchley -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (GNU/Linux) iD4DBQFGimrKFSrKRjX5eCoRAlOeAJIDi2Y2+4ec8FpHpGEaxCa4lamsAKCRKr7g 0U6QjEHvLJWQ7HgfqHn9LQ== =SZ5B -----END PGP SIGNATURE-----