From owner-svn-src-all@FreeBSD.ORG Mon Dec 26 20:32:43 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2001:4f8:fff6::35]) by hub.freebsd.org (Postfix) with ESMTP id D5AD5106564A; Mon, 26 Dec 2011 20:32:43 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from 172-17-198-245.globalsuite.net (hub.freebsd.org [IPv6:2001:4f8:fff6::36]) by mx2.freebsd.org (Postfix) with ESMTP id 6C085150AF5; Mon, 26 Dec 2011 20:32:43 +0000 (UTC) Message-ID: <4EF8D9EB.9010506@FreeBSD.org> Date: Mon, 26 Dec 2011 12:32:43 -0800 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20111222 Thunderbird/9.0 MIME-Version: 1.0 To: Justin Hibbits References: <201112251429.pBPETawV062695@svn.freebsd.org> <4EF812F4.9010902@FreeBSD.org> <0AA7AB29-F489-4C8E-BA2A-85DC6788FFC6@gmail.com> In-Reply-To: <0AA7AB29-F489-4C8E-BA2A-85DC6788FFC6@gmail.com> X-Enigmail-Version: undefined OpenPGP: id=1A1ABC84 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, "Bjoern A. Zeeb" , src-committers@freebsd.org Subject: Re: svn commit: r228874 - head/sys/dev/hwpmc X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Dec 2011 20:32:43 -0000 On 12/26/2011 04:50, Justin Hibbits wrote: > On Dec 26, 2011, at 1:23 AM, Doug Barton wrote: > >> On 12/25/2011 06:29, Bjoern A. Zeeb wrote: >>> Author: bz >>> Date: Sun Dec 25 14:29:36 2011 >>> New Revision: 228874 >>> URL: http://svn.freebsd.org/changeset/base/228874 >>> >>> Log: >>> Quite the tinderbox for the holidays. Remove the assert[1]. >> >> Shouldn't "Why it's Ok to remove the assert" be part of this commit log? > > When I suggested the removal, I didn't see it as necessary, and was just > looking to quiet the build for now while I look closer. Right now, that > code is never called, as it's only used when configured for sampling, > and that code was originally just a copy from the hwpmc_amd driver. I > will be finishing the sampling code in the new year. Thank you for the explanation. -- [^L] Breadth of IT experience, and depth of knowledge in the DNS. Yours for the right price. :) http://SupersetSolutions.com/