From owner-freebsd-current@freebsd.org Thu Nov 16 17:13:56 2017 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 05101DE39D5; Thu, 16 Nov 2017 17:13:56 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C1EF92BBF; Thu, 16 Nov 2017 17:13:55 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (unknown [127.0.1.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by freefall.freebsd.org (Postfix) with ESMTPS id D84A35755; Thu, 16 Nov 2017 17:13:54 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id 162D623FB; Thu, 16 Nov 2017 17:13:54 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id aH01YBnoeiIk; Thu, 16 Nov 2017 17:13:46 +0000 (UTC) Subject: Re: -r325627 of head: mergemaster: Creating objdir after objdir after . . . DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com 0577423F0 To: Mark Millard Cc: FreeBSD Toolchain , FreeBSD Current References: <08a57ee2-ae3e-b8ea-73a3-b6533b0fd206@FreeBSD.org> <202f44cb-39d6-99af-9804-582825ae5c07@FreeBSD.org> <0c9c20c2-1d34-77e8-1620-fb99881a34d1@FreeBSD.org> From: Bryan Drewery Openpgp: id=F9173CB2C3AAEA7A5C8A1F0935D771BB6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Organization: FreeBSD Message-ID: <109a5971-236c-1007-21f6-6bd1cbe3a1cb@FreeBSD.org> Date: Thu, 16 Nov 2017 09:13:48 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="8Sh14RGwniTvEmiiSCSWS3svwlVLOEa5C" X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Nov 2017 17:13:56 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --8Sh14RGwniTvEmiiSCSWS3svwlVLOEa5C Content-Type: multipart/mixed; boundary="pEfxv5nXReVV17CIb3LFDPTdvITww0S4I"; protected-headers="v1" From: Bryan Drewery To: Mark Millard Cc: FreeBSD Toolchain , FreeBSD Current Message-ID: <109a5971-236c-1007-21f6-6bd1cbe3a1cb@FreeBSD.org> Subject: Re: -r325627 of head: mergemaster: Creating objdir after objdir after . . . References: <08a57ee2-ae3e-b8ea-73a3-b6533b0fd206@FreeBSD.org> <202f44cb-39d6-99af-9804-582825ae5c07@FreeBSD.org> <0c9c20c2-1d34-77e8-1620-fb99881a34d1@FreeBSD.org> In-Reply-To: --pEfxv5nXReVV17CIb3LFDPTdvITww0S4I Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 11/11/2017 2:25 PM, Mark Millard wrote: >=20 > On 2017-Nov-11, at 8:47 AM, Bryan Drewery wrote:= >=20 >>> On Nov 11, 2017, at 00:51, Mark Millard wrote: >>> >>>> On 2017-Nov-10, at 5:16 PM, Bryan Drewery = wrote: >>>> >>>>> On 11/10/2017 8:30 AM, Bryan Drewery wrote: >>>>> . . .=20 >>>>> In fact it's similar to my META_MODE whitelist in the top-level >>>>> Makefile. There's quite a few targets we don't care for AUTO_OBJ o= n, >>>>> like distribute*, installworld, installkernel, etc. >>>> >>>> r325697 should fix it. >>> >>> Most of the messages are gone in -r325700 . But there was: >>> >>> *** Creating the temporary root environment in /var/tmp/temproot >>> *** /var/tmp/temproot ready for use >>> *** Creating and populating directory structure in /var/tmp/temproot >>> >>> [Creating objdir /usr/obj/usr/src/arm64.aarch64...] >>> [Creating objdir /usr/obj/usr/src/arm64.aarch64/etc...] >>> [Creating objdir /usr/obj/usr/src/arm64.aarch64/etc/sendmail...] >>> >>> (No more objdir lines after that.) >> >> Yea this is expected. Mergemaster runs =E2=80=98make obj=E2=80=99 in e= tc/. >=20 > Hmm. I looking I see the: >=20 > ${MM_MAKE} _obj SUBDIR_OVERRIDE=3Detc >/dev/null && > ${MM_MAKE} everything SUBDIR_OVERRIDE=3Detc >/dev/null && >=20 > Its too bad that the mergemaster man page makes no reference > to depending on MAKEOBJDIRPREFIX (or its default) and the > tree contents that it points to. If one has more than one > tree around then one should be picking the right one --but > nothing in the man page suggests that. >=20 > It also would not play well with not having that build tree > available at the time of a mergemaster. Can you test this patch please in context of this problem please? It resolves read-only objdirs and should avoid more of the objdir creations at mergemaster/installworld time. It probably will still create the etc/sendmail one. https://people.freebsd.org/~bdrewery/patches/top-level-objdirs.diff >=20 > The 20130425 UPDATING entry does note use of > MAKEOBJDIRPREFIX. It notes that mergemaster makes use of the > specific, bootstrapped mtree and install. Does that mean > that a cross-build needs mergemaster to be executed on > the cross-build host instead of on the target system? I do > not see the man page as well-covering such questions for > the proper usage technique. >=20 > Dependency on /usr/src (by default or an alternate via -m) is > clear from the man page. So, having a proper vintage of such > and having mergemaster use it was clear. But such seems to not > be sufficient, which was not clear. >=20 >> The top-level check-old objdir creation is unavoidable right now... yo= u can use -DNO_OBJ if you want to avoid it. >> >>> >>>>> >>>>>> However from reading mergemaster.sh it seems that _at least_ >>>>>> /usr/obj/usr/src/etc/sendmail would be created before my changes. = Can >>>>>> someone confirm that on stable/ or something? >>>>>> >>>>>>> >>>>>>> (MAKEOBJDIRPREFIX=3D does control the path-prefix used >>>>>>> if specified in the env list before mergemaster.) >>>>>>> >>> >=20 >=20 > =3D=3D=3D > Mark Millard > markmi at dsl-only.net >=20 --=20 Regards, Bryan Drewery --pEfxv5nXReVV17CIb3LFDPTdvITww0S4I-- --8Sh14RGwniTvEmiiSCSWS3svwlVLOEa5C Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJaDcdMAAoJEDXXcbtuRpfPNpYH+gPa1zzx3/pnAh5xtzETjhHx IVN/5TkxR5n4d14Rl/p1iTLP+UyR4IhCGcQm3hoSnF3jcDeIsPk7CDFTqvfF0mWN li6B7jd3T8Epa8DZaHQCkynh3TZ9rHXniGNSimQxdpCZ117Sr6m2OdXE2JFvFhE0 yY0I+c/8qcLHO7SDRL/pMoq5+YTYHlHBgfJp5fHg9RdhEgMUv7898QHrJzs1K4e6 zluWbGEbl0AwvepkC5wk72VghRyUsJjYoQDhuUjcKI3dcPIeK4xeNUYh7MMTnGGa sEjDYjK6TVY9wLdloYWImoyRNLZprvIjLGIXPViSoM/LLqknVbOmnxGcZh51W0g= =xX9I -----END PGP SIGNATURE----- --8Sh14RGwniTvEmiiSCSWS3svwlVLOEa5C--