From owner-freebsd-bugs@FreeBSD.ORG Wed Jan 22 22:40:00 2014 Return-Path: Delivered-To: freebsd-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A635E393 for ; Wed, 22 Jan 2014 22:40:00 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 69EC31B38 for ; Wed, 22 Jan 2014 22:40:00 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id s0MMe0kH091877 for ; Wed, 22 Jan 2014 22:40:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id s0MMe03x091876; Wed, 22 Jan 2014 22:40:00 GMT (envelope-from gnats) Resent-Date: Wed, 22 Jan 2014 22:40:00 GMT Resent-Message-Id: <201401222240.s0MMe03x091876@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Alfred Perlstein Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 62B79F71 for ; Wed, 22 Jan 2014 22:31:20 +0000 (UTC) Received: from oldred.freebsd.org (oldred.freebsd.org [IPv6:2001:1900:2254:206a::50:4]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4FCC21ADC for ; Wed, 22 Jan 2014 22:31:20 +0000 (UTC) Received: from oldred.freebsd.org ([127.0.1.6]) by oldred.freebsd.org (8.14.5/8.14.7) with ESMTP id s0MMVKgJ046593 for ; Wed, 22 Jan 2014 22:31:20 GMT (envelope-from nobody@oldred.freebsd.org) Received: (from nobody@localhost) by oldred.freebsd.org (8.14.5/8.14.5/Submit) id s0MMVKKY046589; Wed, 22 Jan 2014 22:31:20 GMT (envelope-from nobody) Message-Id: <201401222231.s0MMVKKY046589@oldred.freebsd.org> Date: Wed, 22 Jan 2014 22:31:20 GMT From: Alfred Perlstein To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Subject: misc/186020: adb has params to mtx_init reversed X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Jan 2014 22:40:00 -0000 >Number: 186020 >Category: misc >Synopsis: adb has params to mtx_init reversed >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Jan 22 22:40:00 UTC 2014 >Closed-Date: >Last-Modified: >Originator: Alfred Perlstein >Release: current >Organization: Norse Corporation >Environment: current >Description: Args are in wrong order to mtx_init(9) >How-To-Repeat: >Fix: Patch attached with submission follows: Index: adb_kbd.c =================================================================== --- adb_kbd.c (revision 261037) +++ adb_kbd.c (working copy) @@ -304,7 +304,7 @@ /* Try stepping forward to the extended keyboard protocol */ adb_set_device_handler(dev,3); - mtx_init(&sc->sc_mutex,KBD_DRIVER_NAME,MTX_DEF,0); + mtx_init(&sc->sc_mutex,KBD_DRIVER_NAME,NULL, MTX_DEF); cv_init(&sc->sc_cv,KBD_DRIVER_NAME); callout_init(&sc->sc_repeater, 0); Index: adb_mouse.c =================================================================== --- adb_mouse.c (revision 261037) +++ adb_mouse.c (working copy) @@ -154,7 +154,7 @@ sc = device_get_softc(dev); sc->sc_dev = dev; - mtx_init(&sc->sc_mtx,"ams",MTX_DEF,0); + mtx_init(&sc->sc_mtx,"ams",NULL, MTX_DEF); cv_init(&sc->sc_cv,"ams"); sc->flags = 0; >Release-Note: >Audit-Trail: >Unformatted: