From nobody Thu Aug 21 16:51:53 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4c78W00hMRz65Nrq for ; Thu, 21 Aug 2025 16:52:12 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4c78Vz1rVRz3XQP for ; Thu, 21 Aug 2025 16:52:11 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-pj1-x1033.google.com with SMTP id 98e67ed59e1d1-323267bcee7so1568442a91.1 for ; Thu, 21 Aug 2025 09:52:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20230601.gappssmtp.com; s=20230601; t=1755795125; x=1756399925; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=80YiuuhPBNQ4oINnrzxXRpiPh/zqKFwxg/S1HHe0cqY=; b=sMzIyzSMRxqWXvNBtOQi+is8uxIKPoLurSe2Y/kl5gXRqRLdYwfGnmnu+5o/bIdlZ3 4o7/UouPHYzkLkX6LhT50gKPpNEBzg2hJjEfshiQAPetQhvCoueO0HOj1KIYujY6qFi0 yHQdWTaGBjjHJ6GHmeFNsBrom+m5Gferlf9KyHHFSdoO5eFwXCx9VdAczMfWqn0zOolp DGub33BxhM0HrxoHRcpKIJwW1siynMHV3XqXTxEhaAHJDDiptwOkWL05nDWUrx90owWN BBRMy8GDfkfK5B/IsvOHHajlcJ/4yCeqq9E9ZbNHoZENthAYCxp9S9XPY5PGnvQmc+q9 49eA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755795125; x=1756399925; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=80YiuuhPBNQ4oINnrzxXRpiPh/zqKFwxg/S1HHe0cqY=; b=Xxvc6PwYIIiXfnxd+gSXZQCfH+qyuSwmAT3bjXddkFLJi8mKCYWSiZ1Te7AXwNfUG0 b7laY9zyBh10YrWcdQFvRcFZdhVtwPnX5j0vjpuW+aaY32zL9a9Vhh6jbV5wYXQIFIXz f5ocPQarA7ZVjubiBOuS5QBnbuJk8J+lUrOMQOhQcxkCbOspC8nz/dm3vEZS6xx6LZQz /x2Gbb/G/w6T+X9I3vqPc7W3s9Xtdbnnvh7VPfNeZDPCXN/Guf6EuHc5s+wStl0FaCly syMW2yXM+hVgd/HzAnhokdn+HFE9LkImnLDwJkE6XLJ/8yJvK72nsdCt4pwgwZs9nHQ7 R5WQ== X-Forwarded-Encrypted: i=1; AJvYcCWvkBd3S6tiAaqDh/MFm+uSZ9DrY8iC1VRbmT4CjzZVwHrvRBev/jM4RXnISpfETWl/iOFHHsAPsf+B01HLPFE0BWaD@freebsd.org X-Gm-Message-State: AOJu0YxVBLYaKUuUDAwcRNvbKecop6lJqRT32cwCFO3wruY39BHqlXPp bS2rVk2lsptojF6TjXqQFHTMmebFlKnTe0kwW7yFRStIYdPI4/s4LKUeWTI5nH0PFSAwavOcuKw 9Q8w9THcAiD3M4/OBxXmZZ5y5u9717nU38gaC5m8uLw== X-Gm-Gg: ASbGncu2i+HjXa4X0w8CiIyaVV/Gg3pPt/XyfCVKPshP2XDBbtNrXyIGcCSXmlFfIqg 3mLsfGIofFwSdmw06pzNKJfyKzVS4K3B3sSIamgp8/HW6fW9zD3OZaO2HR8GbuKoR9f5ByJ1ZvI KuFvUb6Klqt0ZN4rhgln7xzCJOaoFlLzEV0N4nQIUoATAUCNhIA+6vTS2zxmoQtYdQSzSiSyuzy 9mvyxU9r57gGtX2OQ== X-Google-Smtp-Source: AGHT+IFNEGgp4nJE4SxITc6ZXLddjIMHi1Rx4R02TUzAyCl+MwPPORn8RfkKrMzW+uOQsiPimEu+APRb8qvjBhVvY2M= X-Received: by 2002:a17:90b:4ace:b0:324:ecb2:fabc with SMTP id 98e67ed59e1d1-32515ee3ba6mr231394a91.6.1755795124428; Thu, 21 Aug 2025 09:52:04 -0700 (PDT) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 References: <202508202248.57KMmcTO016280@gitrepo.freebsd.org> <20250821060752.001c9599@thor.sb211.local> <8006s3o4-3nns-509q-n89q-oq88r8o09sn8@SerrOFQ.bet> <9EEDE524-1ED3-4F41-9584-460DCBF61D81@me.com> In-Reply-To: From: Warner Losh Date: Thu, 21 Aug 2025 10:51:53 -0600 X-Gm-Features: Ac12FXwBaGy2N_qiOK3U2Cpd8C_qBX49IzSx79tHXr6-qYf3WXr-d2EKLvUZsy4 Message-ID: Subject: Re: git: b44cc1b479fe - main - loader: do not try to open directories with TFTP To: "Bjoern A. Zeeb" Cc: Toomas Soome , A FreeBSD User , "Simon J. Gerraty" , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Type: multipart/alternative; boundary="000000000000b0b77a063ce2e872" X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4c78Vz1rVRz3XQP --000000000000b0b77a063ce2e872 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Aug 21, 2025 at 1:02=E2=80=AFAM Bjoern A. Zeeb wro= te: > On Thu, 21 Aug 2025, Toomas Soome wrote: > > >> shot in the dark (haven't checked that LOADER_NET_SUPPORT would be > defined for these files): > > > > > > I do not think it is the approach you want to take there, because this > means you would need to build all those variants to build different > components=E2=80=A6 > > > > I would think of having weak is_tftp() implementation returning false > for case the dev_net.c is not built or move dev_net.c into libsa. I=E2=80= =99m not > quite sure why dev_net.c is outside libsa anyhow;) > > Even just moving is_tftp into stand.h would work. > Even better: deleting it entirely. It's not a good solution to the problem. But it's a better solution than what we had before. It will be gone when I do my next loader tech debt reduction pass. I didn't have time to do that before the release, so simon's changes went in. He's since committed an adequate fix. Warner --000000000000b0b77a063ce2e872 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Thu, Aug 21,= 2025 at 1:02=E2=80=AFAM Bjoern A. Zeeb <bz@freebsd.org> wrote:
On Thu, 21 Aug 2025, Toomas Soome wrote:

>> shot in the dark (haven't checked that LOADER_NET_SUPPORT woul= d be defined for these files):
>
>
> I do not think it is the approach you want to take there, because this= means you would need to build all those variants to build different compon= ents=E2=80=A6
>
> I would think of having weak is_tftp() implementation returning false = for case the dev_net.c is not built or move dev_net.c into libsa. I=E2=80= =99m not quite sure why dev_net.c is outside libsa anyhow;)

Even just moving is_tftp into stand.h would work.

=
Even better: deleting it entirely. It's not a good solution = to the problem. But it's a better solution than what we had before. It = will be gone when I do my next loader tech debt reduction pass. I didn'= t have time to do that before the release, so simon's changes went in. = He's since committed an adequate fix.

Warner= =C2=A0
--000000000000b0b77a063ce2e872--