From owner-freebsd-emulation@FreeBSD.ORG  Tue Feb 19 21:52:13 2008
Return-Path: <owner-freebsd-emulation@FreeBSD.ORG>
Delivered-To: emulation@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E577716A419
	for <emulation@freebsd.org>; Tue, 19 Feb 2008 21:52:13 +0000 (UTC)
	(envelope-from rdivacky@vlk.vlakno.cz)
Received: from vlakno.cz (vlk.vlakno.cz [62.168.28.247])
	by mx1.freebsd.org (Postfix) with ESMTP id A05AD13C4CE
	for <emulation@freebsd.org>; Tue, 19 Feb 2008 21:52:12 +0000 (UTC)
	(envelope-from rdivacky@vlk.vlakno.cz)
Received: from localhost (localhost [127.0.0.1])
	by vlakno.cz (Postfix) with ESMTP id 4F4C9674FB5;
	Tue, 19 Feb 2008 22:52:11 +0100 (CET)
X-Virus-Scanned: amavisd-new at vlakno.cz
Received: from vlakno.cz ([127.0.0.1])
	by localhost (vlk.vlakno.cz [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id FSLiHnJTH9Dz; Tue, 19 Feb 2008 22:51:56 +0100 (CET)
Received: from vlk.vlakno.cz (localhost [127.0.0.1])
	by vlakno.cz (Postfix) with ESMTP id 4A9D2674E7E;
	Tue, 19 Feb 2008 22:51:56 +0100 (CET)
Received: (from rdivacky@localhost)
	by vlk.vlakno.cz (8.13.8/8.13.8/Submit) id m1JLptA8034502;
	Tue, 19 Feb 2008 22:51:55 +0100 (CET) (envelope-from rdivacky)
Date: Tue, 19 Feb 2008 22:51:55 +0100
From: Roman Divacky <rdivacky@freebsd.org>
To: Kostik Belousov <kostikbel@gmail.com>
Message-ID: <20080219215155.GA34405@freebsd.org>
References: <20080217163228.GA83107@freebsd.org>
	<20080217193950.GQ57756@deviant.kiev.zoral.com.ua>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20080217193950.GQ57756@deviant.kiev.zoral.com.ua>
User-Agent: Mutt/1.4.2.3i
Cc: emulation@freebsd.org
Subject: Re: [PATCH]: mremap() trivial fixes
X-BeenThere: freebsd-emulation@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Development of Emulators of other operating systems
	<freebsd-emulation.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-emulation>, 
	<mailto:freebsd-emulation-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-emulation>
List-Post: <mailto:freebsd-emulation@freebsd.org>
List-Help: <mailto:freebsd-emulation-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-emulation>, 
	<mailto:freebsd-emulation-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Feb 2008 21:52:14 -0000

On Sun, Feb 17, 2008 at 09:39:50PM +0200, Kostik Belousov wrote:
> On Sun, Feb 17, 2008 at 05:32:28PM +0100, Roman Divacky wrote:
> > hi
> > 
> > www.vlakno.cz/~rdivacky/linux_misc.patch
> > 
> > fixes two trivial issues with mremap(). it sanitizes
> > the input params a little thus fixing two LTP fails
> > 
> > please commit
> 
> Please, supply the commit message.
> Also, the comment about Linux/FreeBSD meaning of the PAGE_MASK shall be
> adjusted to describe the reason for the check first (I suggest simply
> add the "Check for the page alignment" there).

commit message:

Sanitize arguments to linux_mremap(). Check for MREMAP_FIXED
and MREMAP_MAYMOVE flags being mutually exclusive and page alignment
of addr argument.

and I fully agree with the change of the comment. please commit.

thnx a lot

roman