From owner-cvs-all Fri Nov 9 15:57: 7 2001 Delivered-To: cvs-all@freebsd.org Received: from peter3.wemm.org (c1315225-a.plstn1.sfba.home.com [24.14.150.180]) by hub.freebsd.org (Postfix) with ESMTP id 5658037B41C; Fri, 9 Nov 2001 15:56:58 -0800 (PST) Received: from overcee.netplex.com.au (overcee.wemm.org [10.0.0.3]) by peter3.wemm.org (8.11.0/8.11.0) with ESMTP id fA9NuwM02931; Fri, 9 Nov 2001 15:56:58 -0800 (PST) (envelope-from peter@wemm.org) Received: from wemm.org (localhost [127.0.0.1]) by overcee.netplex.com.au (Postfix) with ESMTP id AD00E380A; Fri, 9 Nov 2001 15:56:57 -0800 (PST) (envelope-from peter@wemm.org) X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4 To: Bruce Evans Cc: Poul-Henning Kamp , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/libkern adddi3.c anddi3.c cmpdi2.c iordi3.c locc.c lshldi3.c muldi3.c negdi2.c notdi2.c subdi3.c xordi3.c In-Reply-To: <20011108203658.L1232-100000@delplex.bde.org> Date: Fri, 09 Nov 2001 15:56:57 -0800 From: Peter Wemm Message-Id: <20011109235657.AD00E380A@overcee.netplex.com.au> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Bruce Evans wrote: > On Mon, 5 Nov 2001, Poul-Henning Kamp wrote: > > > phk 2001/11/05 13:10:10 PST > > > > Removed files: > > sys/libkern adddi3.c anddi3.c cmpdi2.c iordi3.c > > locc.c lshldi3.c muldi3.c negdi2.c > > notdi2.c subdi3.c xordi3.c > > Log: > > Garbage call! > > > > These files have been obsoleted by compiler technology (such as it is > > for gcc) for quite some time. > > Whether or not these files are used is machine-dependent. gcc emits > calls to the functions in them as necessary. It just happens to be > unnecessary for all currently supported machines. Similarly in libc, > except optimizing out building of the unused routines is not very > useful there and is only done for i386's. > > Please back this out. Yes: peter@daintree[3:48pm]~src/contrib/gcc-102> grep -r adddi3 . | wc -l 29 peter@daintree[3:49pm]~src/contrib/gcc-103> grep -r anddi3 . | wc -l 14 peter@daintree[3:49pm]~src/contrib/gcc-105> grep -r cmpdi2 . | wc -l 5 peter@daintree[3:49pm]~src/contrib/gcc-106> grep -r iordi3 . | wc -l 12 peter@daintree[3:50pm]~src/contrib/gcc-108> grep -r lshldi3 . | wc -l 0 peter@daintree[3:50pm]~src/contrib/gcc-109> grep -r muldi3 . | wc -l 16 peter@daintree[3:50pm]~src/contrib/gcc-110> grep -r negdi2 . | wc -l 17 peter@daintree[3:50pm]~src/contrib/gcc-111> grep -r notdi2 . | wc -l 0 peter@daintree[3:50pm]~src/contrib/gcc-112> grep -r subdi3 . | wc -l 15 peter@daintree[3:51pm]~src/contrib/gcc-113> grep -r xordi3 . | wc -l 18 notdi2 and lshldi3 probably should go. I'm not sure about locc.c, but there are no apparent references to locc(). Sample references: ./config/alpha/alpha.md:(define_insn "xordi3" ./config/i386/i386.md:(define_insn "xordi3" ... ./config/alpha/alpha.c: seq = emit_insn (gen_subdi3 (stack_pointer_rtx, stack_pointer_rtx, ./config/alpha/alpha.md: emit_insn (gen_subdi3 (tmp, op1, op2)); ./config/alpha/alpha.md: emit_insn (gen_subdi3 (gen_lowpart (DImode, operands[0]), op1, op2)); ./config/alpha/alpha.md:(define_insn "subdi3" ./config/alpha/alpha.md: emit_insn (gen_subdi3 (want, stack_pointer_rtx, ./config/i386/i386.md:(define_insn "subdi3" ./config/sparc/sparc.md:(define_expand "subdi3" ... ./config/alpha/alpha.md:(define_insn "muldi3" ... ./config/alpha/alpha.md:(define_insn "iordi3" ./config/i386/i386.md:(define_insn "iordi3" ./config/sparc/sparc.md:(define_expand "iordi3" ... etc. Therre are lots and lots of possible ways to generate references to these on architectures that we do care about. We just dont have code in the kernel that triggers calls to them at the moment. Please do back this commit out. These are here so that people dont feel the temptation to pull in GPL'ed code from libgcc.a. Cheers, -Peter -- Peter Wemm - peter@FreeBSD.org; peter@yahoo-inc.com; peter@netplex.com.au "All of this is for nothing if we don't go to the stars" - JMS/B5 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message