From owner-svn-src-head@freebsd.org Fri Apr 6 18:37:02 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 30C2DF9D607 for ; Fri, 6 Apr 2018 18:37:02 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x231.google.com (mail-io0-x231.google.com [IPv6:2607:f8b0:4001:c06::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B4C566E434 for ; Fri, 6 Apr 2018 18:37:01 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x231.google.com with SMTP id o4so2783630iod.3 for ; Fri, 06 Apr 2018 11:37:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=9fu0V16jHz0Pt9l8dZpue/kBf6mtYa/J5hPWO0RMTrw=; b=rHFlEz89CMewHNX3qoi8fNOmy+Im4t+dllpxbBWaMkASskS0Uq6+UtvTLyJtfCExpO ao1qIRL4+zcwUZBk+NZP5eA8MX98Z2g+FcI37mhmXbD6AvqXOx6X97mGuePpQLq/dgm2 ar/eyIcz/jfaONahN8WSJulOTE2dDc95/SKy40oMQzOKxg4kbrnQ5vpPwCrH+4Geqaow qECzM/eyDDaJXLSvS3kPvGCFJs9d2uuE/RyjpolsV2lvFZoRvHqhENBOrdVpJS6fvG8z 0TZfdevv7nyw4zt4wyi6jBqvVBa6+7J2QChOpDbI/wsh07uKhcyGTckV8VGesBfNdgEl xtMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=9fu0V16jHz0Pt9l8dZpue/kBf6mtYa/J5hPWO0RMTrw=; b=b/Wt6xxMsIfPc+dy+RPf8WhApEb3eAHheTxkBt4Bztf1vVzIVdigSD10QUKpR7mjjL 65OW5vQOCIpeeuXFwbish/SLO3TjfpXN2xGyNJWoRT7yeQLsiPEcYLfhFeNpb4pOYnX+ ykKMItefxuh+QwbFrmfuOnHbmIfj4yb8Vx9F/6xio4VXn/VsFlNmXfM3T4tPTpF0g0/t 3Hn8uFJGzgUoq+Rxqdg7oZ8YZrCl78TtPV6z2unLvf2yG3KskQLLH2Rv6rza93NKCZO6 PZM8LaywDyZ8DSyPVbZfHAgxoCF+JLpBEzKzj9IvvGYRjfefbl5U8YPUAIDBRM+Ye1u8 6PWQ== X-Gm-Message-State: ALQs6tAFvqOw4whKh0qSEgFBJVfXNJCpyhAgQx6+GDA5w8GmuZwl7YcW 1D0XoLGnC+bEete+CYzdJLgdbKgr2QiV1MkFjW9yVg== X-Google-Smtp-Source: AIpwx49hk2AY5b2II+yo+WLIeqeD1sk8q9HSdAee2oE/1X6giikYbKj4q0BEsNaNAiB+pemunRPA+I5QFzI1kDg83hM= X-Received: by 10.107.18.162 with SMTP id 34mr25119907ios.168.1523039820969; Fri, 06 Apr 2018 11:37:00 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.203.196 with HTTP; Fri, 6 Apr 2018 11:37:00 -0700 (PDT) X-Originating-IP: [2603:300b:6:5100:1052:acc7:f9de:2b6d] In-Reply-To: <8352524.sDEuJtqkT0@ralph.baldwin.cx> References: <201804060257.w362vwi3023158@repo.freebsd.org> <8352524.sDEuJtqkT0@ralph.baldwin.cx> From: Warner Losh Date: Fri, 6 Apr 2018 12:37:00 -0600 X-Google-Sender-Auth: 3LDF9k79Q64N-teCydZZh-e9E7s Message-ID: Subject: Re: svn commit: r332090 - head/stand/i386 To: John Baldwin Cc: Ed Maste , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Apr 2018 18:37:02 -0000 On Fri, Apr 6, 2018 at 11:54 AM, John Baldwin wrote: > On Friday, April 06, 2018 02:57:58 AM Ed Maste wrote: > > Author: emaste > > Date: Fri Apr 6 02:57:58 2018 > > New Revision: 332090 > > URL: https://svnweb.freebsd.org/changeset/base/332090 > > > > Log: > > stand: pass --no-rosegment for i386 bits when linking with lld > > > > btxld does not correctly handle input with other than 2 PT_LOAD > > segments. Passing --no-rosegment lets lld produce output eqivalent to > > ld.bfd: 2 PT_LOAD segments and no PT_GNU_RELRO. > > > > PR: 225775 > > MFC after: 3 weeks > > Sponsored by: The FreeBSD Foundation > > Differential Revision: https://reviews.freebsd.org/D14956 > > > > Modified: > > head/stand/i386/Makefile.inc > > > > Modified: head/stand/i386/Makefile.inc > > ============================================================ > ================== > > --- head/stand/i386/Makefile.inc Fri Apr 6 02:47:43 2018 > (r332089) > > +++ head/stand/i386/Makefile.inc Fri Apr 6 02:57:58 2018 > (r332090) > > @@ -2,8 +2,13 @@ > > # > > # $FreeBSD$ > > > > +.sinclude > > + > > LOADER_ADDRESS?=0x200000 > > LDFLAGS+= -nostdlib > > +.if defined(LINKER_TYPE) && ${LINKER_TYPE} == "lld" > > +LDFLAGS+= -Wl,--no-rosegment > > +.endif > > Maybe we should support LDFLAGS.${LINKER_TYPE} as we do for CFLAGS, etc.? > I concur. It doesn't take too many of these for that to pay off big time, especially if we have to do anything globally... Warner