From nobody Fri Jul 4 20:26:10 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bYlX32mgQz60l8T; Fri, 04 Jul 2025 20:26:11 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bYlX30xXwz3t4h; Fri, 04 Jul 2025 20:26:11 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1751660771; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=yWT9gb8zojP/VWahLnHAKK6KZrSoVhWAKDFOn/7fR+8=; b=RjlyzOf5+suAhFmBkXBAx8ZBa7ZpoJbEYTaF7To5EuSzIk7bGVY9WuPNszI1ub4SQ/fpwC 3ooT5JyONKU5k5SCBdqzncowfR8sfmcnPa3MkKdlldOE1Yv9OJD3/8OkA6EHuXPl1RhAjx jx3A8qdMtAAfWI7P2fOVju9LkV94LRSG7nwg+0vvbZfgj9oO5Bn2S6ENc58F6Mv4nW66G4 d/WkCXihXUat6GrnXS8jTwRC+6zPkR8/izW0KBtRdqIpo3QQ5T/bhg9T4+MHDaywtTV64J qHJPSuwmAGQFeeJQvPvHfmpu1I5nCxCe4SjdGHrXESxaJrZGzJcTm0AZBv/OZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1751660771; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=yWT9gb8zojP/VWahLnHAKK6KZrSoVhWAKDFOn/7fR+8=; b=A9SUmdKWlN7DvEnSgcbitpIcSY7XF4sMWYx62mNvz6CXiVIyfHqkykWifi0qVv7MSdtA5a V0sD5LZXTgtDxNr5xIx0SXAZqibC4rRmxM9lftVvTDEdaRLM2B5bPAgNTQ2HXoSU0MHFl8 Q4HrNEkBAH1/8rDlJ4JCh6ZuFIoWTMMz7K6EjRlTFGyml8soefQfxu52gaT8sGim84UhPl ygQecbBHLmpRZ1uzDNiVJ/6gF+yrAfTQKvnlOjWGKFCLUILV/qSVx02+yrIQBXpFwA/smz mtNxXYSB+KGSrAmdG3c/IqHHK1KHVDDtJhA2RcInha1VJbh4ThyRjxdnjbjmkg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1751660771; a=rsa-sha256; cv=none; b=XZXSQLlG+89nwYm5hm5E2lcxbJRxV8+PAjXCv0ibpDw3H+2qw4chIhS4vQTLOKyHCC4utx Hgoic/1z+8BlX0qdWaAJBNTboIKZaZoV1KGSgEKW4cS2Q8YWrWA0WIvT4eltuAZkvlaQ19 S9N5uri7dLeCw02bK+NYPZd3cy9a1A/N3Ysk2QS1V44/IKe5nKCl6tit7Q6bDiyTp+OtYn 3KNUOME+HAb1U+kzyV+DX5AvmWJTfULhTWk+pbHxqfG9895R1xO1Xat2nPxhSwEfmT3kxp LOmvW/kVLlxNUSbjmbCJFRjnLV5V1vz4XsCrY2py8fUomIcVN4IHvBzTP4dakA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4bYlX26nmLz14j6; Fri, 04 Jul 2025 20:26:10 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 564KQAf2096897; Fri, 4 Jul 2025 20:26:10 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 564KQAV1096894; Fri, 4 Jul 2025 20:26:10 GMT (envelope-from git) Date: Fri, 4 Jul 2025 20:26:10 GMT Message-Id: <202507042026.564KQAV1096894@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Ahmad Khalifa Subject: git: 7f297cdae380 - main - regulator: don't use internal gpiobus function List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: vexeduxr X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 7f297cdae380022bcdc72b3b11d1ecb7a902e578 Auto-Submitted: auto-generated The branch main has been updated by vexeduxr: URL: https://cgit.FreeBSD.org/src/commit/?id=7f297cdae380022bcdc72b3b11d1ecb7a902e578 commit 7f297cdae380022bcdc72b3b11d1ecb7a902e578 Author: Ahmad Khalifa AuthorDate: 2025-07-04 20:03:10 +0000 Commit: Ahmad Khalifa CommitDate: 2025-07-04 20:24:31 +0000 regulator: don't use internal gpiobus function gpiobus_acquire_pin is only meant to be used internally by gpiobus. Use gpio_pin_acquire instead. Reviewed by: manu, mmel Approved by: imp (mentor) Differential Revision: https://reviews.freebsd.org/D50870 --- sys/dev/regulator/regulator_fixed.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/sys/dev/regulator/regulator_fixed.c b/sys/dev/regulator/regulator_fixed.c index 0a76da7140a0..55cdb5e4aeae 100644 --- a/sys/dev/regulator/regulator_fixed.c +++ b/sys/dev/regulator/regulator_fixed.c @@ -100,12 +100,8 @@ static struct gpio_entry * regnode_get_gpio_entry(struct gpiobus_pin *gpio_pin) { struct gpio_entry *entry, *tmp; - device_t busdev; int rv; - busdev = GPIO_GET_BUS(gpio_pin->dev); - if (busdev == NULL) - return (NULL); entry = malloc(sizeof(struct gpio_entry), M_FIXEDREGULATOR, M_WAITOK | M_ZERO); @@ -122,8 +118,8 @@ regnode_get_gpio_entry(struct gpiobus_pin *gpio_pin) } /* Reserve pin. */ - /* XXX Can we call gpiobus_acquire_pin() with gpio_list_mtx held? */ - rv = gpiobus_acquire_pin(busdev, gpio_pin->pin); + /* XXX Can we call gpio_pin_acquire() with gpio_list_mtx held? */ + rv = gpio_pin_acquire(gpio_pin); if (rv != 0) { mtx_unlock(&gpio_list_mtx); free(entry, M_FIXEDREGULATOR);