From owner-freebsd-fs@FreeBSD.ORG  Fri Dec  4 23:50:04 2009
Return-Path: <owner-freebsd-fs@FreeBSD.ORG>
Delivered-To: freebsd-fs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 218A9106566B
	for <freebsd-fs@hub.freebsd.org>; Fri,  4 Dec 2009 23:50:04 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 10D268FC12
	for <freebsd-fs@hub.freebsd.org>; Fri,  4 Dec 2009 23:50:04 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id nB4No3BM080011
	for <freebsd-fs@freefall.freebsd.org>; Fri, 4 Dec 2009 23:50:03 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.3/8.14.3/Submit) id nB4No3eo080010;
	Fri, 4 Dec 2009 23:50:03 GMT (envelope-from gnats)
Date: Fri, 4 Dec 2009 23:50:03 GMT
Message-Id: <200912042350.nB4No3eo080010@freefall.freebsd.org>
To: freebsd-fs@FreeBSD.org
From: Kostik Belousov <kostikbel@gmail.com>
Cc: 
Subject: Re: kern/141177: [zfs] fsync() on FIFO causes panic() on zfs
X-BeenThere: freebsd-fs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Kostik Belousov <kostikbel@gmail.com>
List-Id: Filesystems <freebsd-fs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-fs>
List-Post: <mailto:freebsd-fs@freebsd.org>
List-Help: <mailto:freebsd-fs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 04 Dec 2009 23:50:04 -0000

The following reply was made to PR kern/141177; it has been noted by GNATS.

From: Kostik Belousov <kostikbel@gmail.com>
To: Dominik Ernst <dernst@gmx.de>
Cc: bug-followup@freebsd.org
Subject: Re: kern/141177: [zfs] fsync() on FIFO causes panic() on zfs
Date: Sat, 5 Dec 2009 01:41:31 +0200

 ZFS explicitely puts VOP_PANIC as fsync vop for fifos. I think
 the following patch fixes it.
 
 diff --git a/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c b/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c
 index 7608d76..4f61f5f 100644
 --- a/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c
 +++ b/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c
 @@ -5009,7 +5009,7 @@ struct vop_vector zfs_vnodeops = {
  
  struct vop_vector zfs_fifoops = {
  	.vop_default =		&fifo_specops,
 -	.vop_fsync =		VOP_PANIC,
 +	.vop_fsync =		zfs_freebsd_fsync,
  	.vop_access =		zfs_freebsd_access,
  	.vop_getattr =		zfs_freebsd_getattr,
  	.vop_inactive =		zfs_freebsd_inactive,