From nobody Fri Aug 7 22:14:59 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hGz3R5pfrz6nrnV for ; Fri, 07 Aug 2026 22:14:59 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hGz3R3zCbz3SmR for ; Fri, 07 Aug 2026 22:14:59 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786140899; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=DMH3CoMQU8x8OAhJZpx3A0UOtX7cgHM7uMsJAK4CPHU=; b=AicMSfBEGY1a9d1WRaWTGlNhwwNPHQrE7oBWBScWc87WEUU2hHmvz2qxR85qQ+0/ZnFP1N 8rr/T6A6GngVDmBXKoReCF965nzjpSAB4OQujE3UeKYrs5rXpgJtMLUou6fs1igTnXDta5 T9djmQCYtxdMx1ONk6r5OICpLGy1RNPLyPbt77fUL5ck5xkYQNAiUZJwi4KHV75pAlZlqb ckLy/Pu2hkiT1R8pNUc+31fXEEYMcZOfniX8BhHLTJLKKd+6Aj+Y0VO+yY5yxmtOmWIB7q ZknvzrRYWs0b0l//hZfKLISgHtq+8xsBZEqX7rI7HQkTq8PSGbEob/MnhTax5Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1786140899; a=rsa-sha256; cv=none; b=F5+aICRpuTtoTObuX3Vt8mwEhJbNIAbAsgS01U1BzqvGuQvSbXA2iByC08qM2JGZNZ+das WmrLsr7fEFCrFVP9/qyO0FN3oN9pRdN3ebXJVXfqkAa26DudT8mpfeOzqyQP1HLSEieVzF 6xf0NxCC6uZmn2m669PhmjCSiTOdPHmT/3jbx/2O88LNj3aLv+S5YiYscDx5dCtw/F7wyX QJR0YTuVEozOxd7ek2BhCSLlPrBcI2TYqEQNd5bLpHFllW30wL3l/+jMgvylTGHI5dG6uw iASU+scx6lOB/NW4QtvOS3i9TkJPLCazobJ4KnwihQo1AWD21qTEdO65LEJN2g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786140899; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=DMH3CoMQU8x8OAhJZpx3A0UOtX7cgHM7uMsJAK4CPHU=; b=uF4nxNLHtJ96NxMrca72Zwe1WMCcEWUuspStf0wpydCYYK5EEdnYhTFMS6r7d3qK3b35/2 wSmKXUWwJUmt1qyNEnKnvqSya0QI7BHAI0vKs1FZv8nhTRsom38LNwyuhMVoww/5lovb+F +Razp0h3bVRpdwu2cPQYAwJg0uwTxIKjcStZRLZ1ofm+NOvsFDB3dxr2QPFAETmNsacTCp HHADNWz8l5ok7xmb2SWWW5Ak5K5R9AP0vuoyltnQ3uB/P5FeuSpa84DILkqwcHttnWBV36 Q4aGWSGbBEcqhhCHeYtMrBFjyxPAQhyV84ne9XTs4buSAFxzkDVPDQX7T1QEng== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hGz3R30q4z1PPV for ; Fri, 07 Aug 2026 22:14:59 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 27bfb by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 07 Aug 2026 22:14:59 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Gleb Smirnoff Subject: git: 2ae8976a3f6a - main - ocs_fc: return correct error code from ocs_hw_set_persistent_topology() List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: glebius X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 2ae8976a3f6a7e4deb1905326145f5c2575264f4 Auto-Submitted: auto-generated Date: Fri, 07 Aug 2026 22:14:59 +0000 Message-Id: <6a7658e3.27bfb.1d5229ad@gitrepo.freebsd.org> The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=2ae8976a3f6a7e4deb1905326145f5c2575264f4 commit 2ae8976a3f6a7e4deb1905326145f5c2575264f4 Author: Gleb Smirnoff AuthorDate: 2026-08-07 20:46:22 +0000 Commit: Gleb Smirnoff CommitDate: 2026-08-07 22:14:53 +0000 ocs_fc: return correct error code from ocs_hw_set_persistent_topology() No functional change, as current callers either don't check the return value or check it against OCS_HW_RTN_SUCCESS only. Found with: clang -Werror=assign-enum --- sys/dev/ocs_fc/ocs_hw.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sys/dev/ocs_fc/ocs_hw.c b/sys/dev/ocs_fc/ocs_hw.c index 62ef3cd49be3..f4935db8f321 100644 --- a/sys/dev/ocs_fc/ocs_hw.c +++ b/sys/dev/ocs_fc/ocs_hw.c @@ -12209,7 +12209,7 @@ ocs_hw_set_persistent_topology(ocs_hw_t *hw, uint32_t topology, uint32_t opts) default: ocs_log_err(hw->os, "unsupported topology %#x\n", topology); - return -1; + return OCS_HW_RTN_ERROR; } ocs_sem_init(&request.semaphore, 0, "set_persistent_topo"); @@ -12235,12 +12235,12 @@ ocs_hw_set_persistent_topology(ocs_hw_t *hw, uint32_t topology, uint32_t opts) if (ocs_sem_p(&request.semaphore, OCS_SEM_FOREVER)) { ocs_log_err(hw->os, "ocs_sem_p failed\n"); - return -ENXIO; + return OCS_HW_RTN_ERROR; } if (request.status) { ocs_log_err(hw->os, "set persistent topology failed; status: %d\n", request.status); - return -EFAULT; + return OCS_HW_RTN_ERROR; } }