Date: Sun, 20 Oct 2019 17:41:29 +0000 From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 236724] igb(4): Interfaces fail to switch active to inactive state Message-ID: <bug-236724-7501-Wt36uKv9rJ@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-236724-7501@https.bugs.freebsd.org/bugzilla/> References: <bug-236724-7501@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D236724 --- Comment #18 from commit-hook@freebsd.org --- A commit references this bug: Author: marius Date: Sun Oct 20 17:40:50 UTC 2019 New revision: 353778 URL: https://svnweb.freebsd.org/changeset/base/353778 Log: - In em_intr(), just call em_handle_link() instead of duplicating it. - In em_msix_link(), properly handle IGB-class devices after the iflib(4) conversion again by only setting EM_MSIX_LINK for the EM-class 82574 and by re-arming link interrupts unconditionally, i. e. not only in case of spurious interrupts. This fixes the interface link state change detection for the IGB-class. [1] - In em_if_update_admin_status(), only re-arm the link state change interrupt for 82574 and also only if such a device uses MSI-X, i. e. takes advantage of autoclearing. In case of INTx and MSI as well as for LEM- and IGB-class devices, re-arming isn't appropriate here and setting EM_MSIX_LINK isn't either. While at it, consistently take advantage of the hw variable. PR: 236724 [1] Differential Revision: https://reviews.freebsd.org/D21924 Changes: head/sys/dev/e1000/if_em.c --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-236724-7501-Wt36uKv9rJ>