From owner-p4-projects@FreeBSD.ORG  Thu Jul 12 16:31:27 2007
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id D2AC716A421; Thu, 12 Jul 2007 16:31:26 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id AB18B16A476
	for <perforce@freebsd.org>; Thu, 12 Jul 2007 16:31:26 +0000 (UTC)
	(envelope-from hselasky@c2i.net)
Received: from swip.net (mailfe12.swip.net [212.247.155.97])
	by mx1.freebsd.org (Postfix) with ESMTP id 1A96D13C459
	for <perforce@freebsd.org>; Thu, 12 Jul 2007 16:31:25 +0000 (UTC)
	(envelope-from hselasky@c2i.net)
X-Cloudmark-Score: 0.000000 []
Received: from [212.17.141.53] (account mc467741@c2i.net HELO [10.150.81.62])
	by mailfe12.swip.net (CommuniGate Pro SMTP 5.1.10)
	with ESMTPA id 373309223; Thu, 12 Jul 2007 18:31:21 +0200
From: Hans Petter Selasky <hselasky@c2i.net>
To: "Constantine A. Murenin" <cnst@freebsd.org>
Date: Thu, 12 Jul 2007 18:31:22 +0200
User-Agent: KMail/1.9.5
References: <200707121428.l6CESBSj045007@repoman.freebsd.org>
	<46965433.6050207@FreeBSD.org>
In-Reply-To: <46965433.6050207@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200707121831.22913.hselasky@c2i.net>
Cc: Shteryana Shopova <syrinx@freebsd.org>,
	Perforce Change Reviews <perforce@freebsd.org>,
	Alexey Tarasov <taleks@freebsd.org>
Subject: Re: PERFORCE change 123376 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 12 Jul 2007 16:31:27 -0000

On Thursday 12 July 2007 18:17, Constantine A. Murenin wrote:
> On 12/07/2007 10:28, Alexey Tarasov wrote:
> > http://perforce.freebsd.org/chv.cgi?CH=123376
> >
> > Change 123376 by taleks@taleks_th on 2007/07/12 14:27:18
>
> ...
>
> > @@ -104,11 +107,11 @@
> >  	}
> >
> >  	if ( (from == 0) && (size == 0) ) {
> > -		sprintf(http_data, "GET /%s HTTP/1.1\r\nHost: %s\r\nConnection:
> > Close\r\n\r\n", +		sprintf(http_data, "GET /%s HTTP/1.1\r\nHost:
> > %s\r\nConnection: Close\r\nUser-Agent: pxe_http/0\r\n\r\n", filename,
> > server_name
> >  		);
> >  	} else {
> > -		sprintf(http_data, "GET /%s HTTP/1.1\r\nHost: %s\r\nRange:
> > %d-%d\r\nConnection: Close\r\n\r\n", +		sprintf(http_data, "GET /%s
> > HTTP/1.1\r\nHost: %s\r\nRange: bytes=%d-%d\r\nConnection:
> > Close\r\nUser-Agent: pxe_http/0\r\n\r\n", filename, server_name, from,
> > from + size
> >  		);
> >  	}
>
> You might want to change long lines like these to something as follows:
>
> 	if ( (from == 0) && (size == 0) )
> 		sprintf(http_data, "GET /%s HTTP/1.1\r\nHost: %s\r\n"
> 		    "Connection: Close\r\nUser-Agent: pxe_http/0\r\n\r\n",
> 		    filename, server_name);
> 	else
> 		sprintf(http_data, "GET /%s HTTP/1.1\r\nHost: %s\r\n"
> 		    "Range: bytes=%d-%d\r\n"
> 		    "Connection: Close\r\nUser-Agent: pxe_http/0\r\n\r\n",
> 		    filename, server_name, from, from + size);
>
> Also note that ");" should not appear on a line by itself, if I'm reading
> style(9) correctly.
>
> Removing curly brackets is optional in this case, because lines are
> somewhat long, but personally, I do like them removed, too. :)
>

And, don't use "sprintf". Use "snprintf" instead.

--HPS