From nobody Wed Aug 6 06:02:26 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bxfpC1kBqz64Dw7; Wed, 06 Aug 2025 06:02:27 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bxfpB6zdXz3t7J; Wed, 06 Aug 2025 06:02:26 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1754460147; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=xNgeDlmWL78w3Ldqdy6okB17rM3ZFquOSeHeiQbP9QY=; b=j9leDQurpkgeu3mjm4KJZMTSw1fk2mY0VIU2q1uCGShN02LGOMn+d6GU316bpOHEQFhiI6 XRw9TWdCPQTFRTePvNhqNc6goAau9Ss8o+oC8HbEIH5R6EQEfXsJrnIKUkZJy4WZFO48/8 fL4V87LOA0O5Juk1J9kgpQVITDvqRPNTh6Htiap/RjhBXKmEi0WxbbUDSf8XYYRzLSOfZx K8RbHawIJvs638KaOBz+2y3PPcCOLGCckYtdevuYpEz9H8tEbaP+fTZEy5rfW1V2Bx4eMb wgQllZ1bc8iN1yocQnVhHC3944MW50+38XEr4H4kbdPBIuFuoNG+YP+3LxPiUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1754460147; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=xNgeDlmWL78w3Ldqdy6okB17rM3ZFquOSeHeiQbP9QY=; b=sBycvdFDXkmYtwO8r8OMnNHvsoMZBtarIJYp99W+Rs3PvW5Kd6KBK3b9sla9pUB7MtJbIn O8ZUCEngVBtJNiX2030uyT9gwDzgp31a3Lr5LmS0/k8aRa9cmSgJz+gTZ4VA+ci3G4251v kJSvz+P7K0qQq98FcXOLSJOP4EQWUbwVPR5qTe46aUpvTPyOWEWn2W5PVJ5ut8009Nxx2T 4UVtEb3n7juK12uTqmjjH1RZ6w5MJNgXl5djfkrZlyugWdZ5mPOczzhniUBOQ6y6nzjNXo VPgC2cuS6Yd4rCHwyk828M+T7xv7pAg4jHmfazW43fj1fMNkshPOZLxl73Uivw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1754460147; a=rsa-sha256; cv=none; b=lCbTT9jeQ9AFhdn8nnJtZkkxVIEJ70/sKC0ibuuOGutHyg3SMyraOc8M2lmSIdt4xZ2MyE b536hHOd/WsN901UrNrl5s+iCaLa1fFe74jPByl9zQFLlLXScA/5O7A5ZYjo1cCeZOFS0I OaYBDSFVvklMVkQX3/jw003iatahzh256fOZ13VCydaMR+3oZdvGoA64a1ha9h50ixpLF3 AyQ+wDY3Z61shNxTvZgw+wQZX6VL9zFQbfBMdKG9FlhYCPtHWlKjt9qJ6d480QeLCSh3jk paAbssM7SfhTkFBvNCs6NYre+z2DNRpDJKhjVgAEoGM5nFG1O9bZ6yB9Xpbpyg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4bxfpB63Xbz17nL; Wed, 06 Aug 2025 06:02:26 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 57662QDw076705; Wed, 6 Aug 2025 06:02:26 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 57662Qm9076702; Wed, 6 Aug 2025 06:02:26 GMT (envelope-from git) Date: Wed, 6 Aug 2025 06:02:26 GMT Message-Id: <202508060602.57662Qm9076702@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Andriy Gapon Subject: git: d4d7b768bb8e - stable/14 - mmc_da: garbage-collect sdda_get_max_data List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: avg X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: d4d7b768bb8e6d1915f9bbb5ba1d2fc705ce1ec2 Auto-Submitted: auto-generated The branch stable/14 has been updated by avg: URL: https://cgit.FreeBSD.org/src/commit/?id=d4d7b768bb8e6d1915f9bbb5ba1d2fc705ce1ec2 commit d4d7b768bb8e6d1915f9bbb5ba1d2fc705ce1ec2 Author: Andriy Gapon AuthorDate: 2025-07-04 07:53:11 +0000 Commit: Andriy Gapon CommitDate: 2025-08-06 06:00:39 +0000 mmc_da: garbage-collect sdda_get_max_data The function is unused since 5aedb8b1d4a6. For information, in MMC CAM both XPT_GET_TRAN_SETTINGS and XPT_PATH_INQ obtain data using MMC_SIM_GET_TRAN_SETTINGS. So, "overlapping" information like ccb_trans_settings_mmc::host_max_data and ccb_pathinq::maxio is derived from the same source. That's why sdda_get_max_data was redundant. Reported by: bz (cherry picked from commit ad0c3859a9184036484c0cd63d7260a4a3d1ad2d) --- sys/cam/mmc/mmc_da.c | 21 --------------------- 1 file changed, 21 deletions(-) diff --git a/sys/cam/mmc/mmc_da.c b/sys/cam/mmc/mmc_da.c index 594426d288cf..d6f8b514e183 100644 --- a/sys/cam/mmc/mmc_da.c +++ b/sys/cam/mmc/mmc_da.c @@ -1199,27 +1199,6 @@ sdda_get_host_caps(struct cam_periph *periph, union ccb *ccb) return (cts->host_caps); } -static uint32_t -sdda_get_max_data(struct cam_periph *periph, union ccb *ccb) -{ - struct ccb_trans_settings_mmc *cts; - - cts = &ccb->cts.proto_specific.mmc; - memset(cts, 0, sizeof(struct ccb_trans_settings_mmc)); - - ccb->ccb_h.func_code = XPT_GET_TRAN_SETTINGS; - ccb->ccb_h.flags = CAM_DIR_NONE; - ccb->ccb_h.retry_count = 0; - ccb->ccb_h.timeout = 100; - ccb->ccb_h.cbfcnp = NULL; - xpt_action(ccb); - - if (ccb->ccb_h.status != CAM_REQ_CMP) - panic("Cannot get host max data"); - KASSERT(cts->host_max_data != 0, ("host_max_data == 0?!")); - return (cts->host_max_data); -} - static void sdda_start_init(void *context, union ccb *start_ccb) {