From owner-cvs-all@FreeBSD.ORG  Thu Mar 24 19:49:02 2005
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 9D7DD16A4CE; Thu, 24 Mar 2005 19:49:02 +0000 (GMT)
Received: from fafoe.narf.at (chello213047085026.6.14.vie.surfer.at
	[213.47.85.26])	by mx1.FreeBSD.org (Postfix) with ESMTP
	id DC84C43D4C; Thu, 24 Mar 2005 19:49:01 +0000 (GMT)
	(envelope-from stefan@fafoe.narf.at)
Received: from wombat.fafoe.narf.at (wombat.fafoe.narf.at [192.168.1.42])
	by fafoe.narf.at (Postfix) with ESMTP id 76CA43FA7;
	Thu, 24 Mar 2005 20:48:56 +0100 (CET)
Received: by wombat.fafoe.narf.at (Postfix, from userid 1001)
	id C640D112; Thu, 24 Mar 2005 20:48:53 +0100 (CET)
Date: Thu, 24 Mar 2005 20:48:53 +0100
From: Stefan Farfeleder <stefan@fafoe.narf.at>
To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org,
	cvs-all@FreeBSD.org
Message-ID: <20050324194852.GJ46915@wombat.fafoe.narf.at>
References: <200503241751.j2OHpFQg063306@repoman.freebsd.org>
	<200503241333.53622.jhb@FreeBSD.org> <20050324192502.GB7294@odin.ac.hmc.edu>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20050324192502.GB7294@odin.ac.hmc.edu>
User-Agent: Mutt/1.5.9i
cc: Brooks Davis <brooks@one-eyed-alien.net>
cc: John Baldwin <jhb@FreeBSD.org>
Subject: Re: cvs commit: src/sys/compat/linux linux_ioctl.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 24 Mar 2005 19:49:02 -0000

On Thu, Mar 24, 2005 at 11:25:02AM -0800, Brooks Davis wrote:
> On Thu, Mar 24, 2005 at 01:33:53PM -0500, John Baldwin wrote:
> > On Thursday 24 March 2005 12:51 pm, Brooks Davis wrote:
> > > brooks      2005-03-24 17:51:15 UTC
> > >
> > >   FreeBSD src repository
> > >
> > >   Modified files:
> > >     sys/compat/linux     linux_ioctl.c
> > >   Log:
> > >   Compile errors are way more useful then panics later.
> > >
> > >   Replace a KASSERT of LINUX_IFNAMSIZ == IFNAMSIZ with a preprocessor
> > >   check and #error message.  This will prevent nasty suprises if users
> > >   change IFNAMSIZ without updating the linux code appropriatly.
> > 
> > There's a CTASSERT() macro that you can use for compile time assertions.
> 
> Ah, intresting.  It produces a less informative error, but I guess the
> fact that it should work on any C compiler makes up for it.  I'll switch
> to that.

Do you imply there's a C compiler which can't handle #if and #error?

Stefan