Date: Tue, 21 Jan 2003 21:19:48 -0800 (PST) From: Matthew Dillon <dillon@apollo.backplane.com> To: "Matthew N. Dodd" <winter@jurai.net> Cc: hackers@FreeBSD.ORG, Hiten Pandya <hiten@unixdaemons.com> Subject: Re: patch to remove random #define MIN/MAX implementations from around the kernel Message-ID: <200301220519.h0M5JmhD000824@apollo.backplane.com> References: <20030121235501.N59276-100000@sasami.jurai.net>
next in thread | previous in thread | raw e-mail | index | archive | help
:I'd like to see all of these changed to the inlines in sys/libkern.h since
:the compiler will do type checking for us.
:
:This is a little more work which is why I didn't do it myself when I dealt
:with the abs() stuff.
:
:Consider this my objection.
:
:I don't think that it really stands in the way of the cleanup of all the
:definitions of min/max etc.
:
:--
:| Matthew N. Dodd | '78 Datsun 280Z | '75 Volvo 164E | FreeBSD/NetBSD |
This might be useful follow-up work. i.e. the idea of getting rid of
the use of the MIN and MAX macros in the kernel altogether. Though I'm
not sure I like the fact that 'min' and 'max' in sys/libkern.h refer
to unsigned ints (it really should be umin and umax or uimin and uimax).
That's a real problem.
-Matt
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200301220519.h0M5JmhD000824>