From owner-cvs-all Thu Mar 7 12:33:33 2002 Delivered-To: cvs-all@freebsd.org Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by hub.freebsd.org (Postfix) with ESMTP id BA7AF37B405; Thu, 7 Mar 2002 12:33:24 -0800 (PST) Received: by elvis.mu.org (Postfix, from userid 1192) id 8AFC2AE24A; Thu, 7 Mar 2002 12:33:24 -0800 (PST) Date: Thu, 7 Mar 2002 12:33:24 -0800 From: Alfred Perlstein To: Mike Silbersack Cc: David O'Brien , Mark Murray , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/usr.bin/rwall rwall.c Message-ID: <20020307203324.GH26621@elvis.mu.org> References: <20020307120711.A62212@dragon.nuxi.com> <20020307142738.U3443-100000@patrocles.silby.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20020307142738.U3443-100000@patrocles.silby.com> User-Agent: Mutt/1.3.27i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG * Mike Silbersack [020307 12:26] wrote: > > On Thu, 7 Mar 2002, David O'Brien wrote: > > > On Thu, Mar 07, 2002 at 01:28:24PM +0000, Mark Murray wrote: > > > > This is by *NO* means more readable than the old code! > > > > > > I guess this comes down to an opinion, right? :-) > > > > There seems to be more NO's than agreements with you in this case. BUT > > that does not matter. We've operated under the "don't change things w/o > > a good reason" to (1) settle cases of opinion like this. And (2) because > > changing things too much throws away over a decade of tested proven code. > > This is something that should not be taken lightly. We hold our age up > > all the time as one of our advantages over Linux. However these > > WARNS/lint runs are making our code as volatile as the GNU stuff we snub. > > I believe I've asked this before, but I haven't heard a good answer: > > What benefit do the WARNS changes have? > > I'd understand the need for "strcpy -> strlcpy changes" or "snprintf > changes", but I don't see what good the WARNS changes are having. Is this > documented somewhere? I'm not sure about it being documented however my point of view is that it gives us code that can be compiled with a high number of compiler diagnostics turned on to prevent and aid in preventing future mistakes. -- -Alfred Perlstein [alfred@freebsd.org] 'Instead of asking why a piece of software is using "1970s technology," start asking why software is ignoring 30 years of accumulated wisdom.' Tax deductible donations for FreeBSD: http://www.freebsdfoundation.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message