From owner-cvs-all@FreeBSD.ORG  Wed Nov 19 01:51:42 2003
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id B380216A4CE; Wed, 19 Nov 2003 01:51:42 -0800 (PST)
Received: from axl.seasidesoftware.co.za (axl.seasidesoftware.co.za
	[196.31.7.201])	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 18A3343F93; Wed, 19 Nov 2003 01:51:41 -0800 (PST)
	(envelope-from sheldonh@starjuice.net)
Received: from sheldonh by axl.seasidesoftware.co.za with local (Exim 4.24;
	FreeBSD)	id 1AMOzq-0007uv-9c; Wed, 19 Nov 2003 11:51:38 +0200
Date: Wed, 19 Nov 2003 11:51:38 +0200
From: Sheldon Hearn <sheldonh@starjuice.net>
To: Wes Peters <wes@FreeBSD.org>
Message-ID: <20031119095138.GA752@starjuice.net>
Mail-Followup-To: Wes Peters <wes@FreeBSD.org>,
	src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org
References: <200311160710.hAG7AtRR047311@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200311160710.hAG7AtRR047311@repoman.freebsd.org>
User-Agent: Mutt/1.5.4i
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sbin/fsck_ffs setup.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Nov 2003 09:51:42 -0000

On (2003/11/15 23:10), Wes Peters wrote:

>   FreeBSD src repository
> 
>   Modified files:
>     sbin/fsck_ffs        setup.c 
>   Log:
>   Catch and report on filesystems that were interrupted during newfs,
>   sporting the new 'BAD' magic number.  Exit with a unique error code
>   (11) so callers who care about this can respond appropriately.

Can you document this unique error code gracefully so that authors of
such callers get clued in easily?

Doing so will probably require choosing a reasonable, existing errno and
documenting its return in the DIAGNOSTICS section of fsck_ffs(8).

That's the first place I'd look for something like this if I were the
author of a caller that cares.

Ciao,
Sheldon.