From owner-svn-src-head@freebsd.org Mon Sep 25 11:11:03 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9B907E10D6E; Mon, 25 Sep 2017 11:11:03 +0000 (UTC) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from mx1.sbone.de (mx1.sbone.de [IPv6:2a01:4f8:130:3ffc::401:25]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client CN "mx1.sbone.de", Issuer "SBone.DE" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 5A0C276A08; Mon, 25 Sep 2017 11:11:03 +0000 (UTC) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:31::2013:587]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.sbone.de (Postfix) with ESMTPS id C6CED25D3857; Mon, 25 Sep 2017 11:10:59 +0000 (UTC) Received: from content-filter.sbone.de (content-filter.sbone.de [IPv6:fde9:577b:c1a9:31::2013:2742]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id 00776D1F908; Mon, 25 Sep 2017 11:10:58 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:31::2013:587]) by content-filter.sbone.de (content-filter.sbone.de [fde9:577b:c1a9:31::2013:2742]) (amavisd-new, port 10024) with ESMTP id QJi0CRiBspsv; Mon, 25 Sep 2017 11:10:57 +0000 (UTC) Received: from [192.168.124.1] (fresh-ayiya.sbone.de [IPv6:fde9:577b:c1a9:f001::2]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id A86E8D1F7FD; Mon, 25 Sep 2017 11:10:50 +0000 (UTC) From: "Bjoern A. Zeeb" To: "Stephen Hurd" Cc: "Stephen Hurd" , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r323942 - head/sys/net Date: Mon, 25 Sep 2017 11:10:48 +0000 Message-ID: <4523452E-79B0-494A-B44F-44DE4B747D69@lists.zabbadoz.net> In-Reply-To: <89d68ff8-84ed-83a6-4e77-9a321babe2fe@sasktel.net> References: <201709230135.v8N1ZE6S063264@repo.freebsd.org> <283397c7-a01e-3776-7ed3-b64d68003d0b@sasktel.net> <6F5DC92C-2CF6-4A33-9663-BFECB7DB65F2@lists.zabbadoz.net> <89d68ff8-84ed-83a6-4e77-9a321babe2fe@sasktel.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed; markup=markdown Content-Transfer-Encoding: quoted-printable X-Mailer: MailMate (2.0BETAr6091) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Sep 2017 11:11:03 -0000 On 23 Sep 2017, at 23:46, Stephen Hurd wrote: > Bjoern A. Zeeb wrote: >> On 23 Sep 2017, at 6:32, Stephen Hurd wrote: >> >>> Bjoern A. Zeeb wrote: >>>> On 23 Sep 2017, at 1:35, Stephen Hurd wrote: >>>> >>>>> Author: shurd >>>>> Date: Sat Sep 23 01:35:14 2017 >>>>> New Revision: 323942 >>>>> URL: https://svnweb.freebsd.org/changeset/base/323942 >>>>> >>>>> Log: >>>>> Chain mbufs before passing to if_input() >>>>> >>>>> Build a list of mbufs to pass to if_input() after LRO. Results = >>>>> in >>>>> 12% small packet forwarding rate improvement. >>>> forwarding seems a confusing word here.. >>> >>> The test was small (64 byte frames) received on one interface, then = >>> sent out on a different one using the net.inet.ip.forwarding sysctl = >>> (controlled via the gateway_enable setting in rc.conf). >> >> Then this makes no sense as we don=E2=80=99t do LRO if forwarding is = >> enabled on the machine; >> https://svnweb.freebsd.org/base/head/sys/netinet/tcp_lro.c?annotate=3D= 317390#l645 > > Basically, it changed from this: =2E. > To this: =E2=80=A6 > So while before it called if_input() for each separate mbuf that was = > not LROed, it now builds a chain of mbufs that were not LROed, and = > makes a single call to if_input() with the whole chain. For cases = > like packet forwarding where no packets are LROed, performance is = > better. Got it, so the =E2=80=9Cafter LRO=E2=80=9D in the original commit message= is as = confusing as forwarding. I not saying anything against the change, I am just saying the commit = message doesn=E2=80=99t describe what it does. Also I am pretty sure this works with ether_input but not so much with = fddi_input, iso88025_input, and ifdead_input is probably going to leak = as well. /bz