Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 13 Sep 2012 17:20:36 GMT
From:      svn-freebsd-gecko@chruetertee.ch
To:        freebsd-gecko@freebsd.org
Subject:   [SVN-Commit] r1016 - in trunk: mail/thunderbird-esr/files www/firefox-esr/files www/libxul-esr/files
Message-ID:  <201209131720.q8DHKaXQ020437@trillian.chruetertee.ch>

next in thread | raw e-mail | index | archive | help
Author: jbeich
Date: Thu Sep 13 17:20:35 2012
New Revision: 1016

Log:
make clang3.2 choke on mismatched visibility early on (always)

If you want benefits of gcc_hidden.h better use clang3.1.

PR:	ports/171566

Added:
   trunk/mail/thunderbird-esr/files/patch-clang32-visibility-hack
   trunk/www/firefox-esr/files/patch-clang32-visibility-hack
   trunk/www/libxul-esr/files/patch-clang32-visibility-hack
Deleted:
   trunk/mail/thunderbird-esr/files/patch-clang32-libc++-visibility-hack
   trunk/www/firefox-esr/files/patch-clang32-libc++-visibility-hack
   trunk/www/libxul-esr/files/patch-clang32-libc++-visibility-hack

Deleted: trunk/mail/thunderbird-esr/files/patch-clang32-libc++-visibility-hack
==============================================================================
--- trunk/mail/thunderbird-esr/files/patch-clang32-libc++-visibility-hack	Thu Sep 13 17:20:35 2012	(r1015)
+++ /dev/null	00:00:00 1970	(deleted)
@@ -1,57 +0,0 @@
---- configure.in~
-+++ configure.in
-@@ -2855,6 +2855,7 @@ EOF
- #pragma GCC visibility push(hidden)
- #pragma GCC visibility push(default)
- #include <string.h>
-+#include <iterator>
- #pragma GCC visibility pop
- 
- __attribute__ ((visibility ("default"))) void Func() {
-@@ -2863,7 +2864,7 @@ __attribute__ ((visibility ("default"))) void Func() {
- }
- EOF
-                        ac_cv_have_visibility_builtin_bug=no
--                       if ! ${CC-cc} ${CFLAGS} ${DSO_PIC_CFLAGS} ${DSO_LDOPTS} -O2 -S -o conftest.S conftest.c > /dev/null 2>&1 ; then
-+                       if ! ${CXX-c++} ${CXXFLAGS} ${DSO_PIC_CFLAGS} ${DSO_LDOPTS} -O2 -S -o conftest.S conftest.c > /dev/null 2>&1 ; then
-                          ac_cv_have_visibility_builtin_bug=yes
-                        else
-                          if test `grep -c "@PLT" conftest.S` = 0; then
---- mozilla/configure.in~
-+++ mozilla/configure.in
-@@ -2855,6 +2855,7 @@ EOF
- #pragma GCC visibility push(hidden)
- #pragma GCC visibility push(default)
- #include <string.h>
-+#include <iterator>
- #pragma GCC visibility pop
- 
- __attribute__ ((visibility ("default"))) void Func() {
-@@ -2863,7 +2864,7 @@ __attribute__ ((visibility ("default"))) void Func() {
- }
- EOF
-                        ac_cv_have_visibility_builtin_bug=no
--                       if ! ${CC-cc} ${CFLAGS} ${DSO_PIC_CFLAGS} ${DSO_LDOPTS} -O2 -S -o conftest.S conftest.c > /dev/null 2>&1 ; then
-+                       if ! ${CXX-c++} ${CXXFLAGS} ${DSO_PIC_CFLAGS} ${DSO_LDOPTS} -O2 -S -o conftest.S conftest.c > /dev/null 2>&1 ; then
-                          ac_cv_have_visibility_builtin_bug=yes
-                        else
-                          if test `grep -c "@PLT" conftest.S` = 0; then
---- mozilla/js/src/configure.in~
-+++ mozilla/js/src/configure.in
-@@ -2855,6 +2855,7 @@ EOF
- #pragma GCC visibility push(hidden)
- #pragma GCC visibility push(default)
- #include <string.h>
-+#include <iterator>
- #pragma GCC visibility pop
- 
- __attribute__ ((visibility ("default"))) void Func() {
-@@ -2863,7 +2864,7 @@ __attribute__ ((visibility ("default"))) void Func() {
- }
- EOF
-                        ac_cv_have_visibility_builtin_bug=no
--                       if ! ${CC-cc} ${CFLAGS} ${DSO_PIC_CFLAGS} ${DSO_LDOPTS} -O2 -S -o conftest.S conftest.c > /dev/null 2>&1 ; then
-+                       if ! ${CXX-c++} ${CXXFLAGS} ${DSO_PIC_CFLAGS} ${DSO_LDOPTS} -O2 -S -o conftest.S conftest.c > /dev/null 2>&1 ; then
-                          ac_cv_have_visibility_builtin_bug=yes
-                        else
-                          if test `grep -c "@PLT" conftest.S` = 0; then

Added: trunk/mail/thunderbird-esr/files/patch-clang32-visibility-hack
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ trunk/mail/thunderbird-esr/files/patch-clang32-visibility-hack	Thu Sep 13 17:20:35 2012	(r1016)
@@ -0,0 +1,30 @@
+--- configure.in~
++++ configure.in
+@@ -3230,6 +3230,7 @@ EOF
+                        ac_cv_have_visibility_class_bug,
+                        [cat > conftest.c <<EOF
+ #pragma GCC visibility push(hidden)
++struct TestStruct;
+ struct __attribute__ ((visibility ("default"))) TestStruct {
+   static void Init();
+ };
+--- mozilla/configure.in~
++++ mozilla/configure.in
+@@ -3230,6 +3230,7 @@ EOF
+                        ac_cv_have_visibility_class_bug,
+                        [cat > conftest.c <<EOF
+ #pragma GCC visibility push(hidden)
++struct TestStruct;
+ struct __attribute__ ((visibility ("default"))) TestStruct {
+   static void Init();
+ };
+--- mozilla/js/src/configure.in~
++++ mozilla/js/src/configure.in
+@@ -3230,6 +3230,7 @@ EOF
+                        ac_cv_have_visibility_class_bug,
+                        [cat > conftest.c <<EOF
+ #pragma GCC visibility push(hidden)
++struct TestStruct;
+ struct __attribute__ ((visibility ("default"))) TestStruct {
+   static void Init();
+ };

Deleted: trunk/www/firefox-esr/files/patch-clang32-libc++-visibility-hack
==============================================================================
--- trunk/www/firefox-esr/files/patch-clang32-libc++-visibility-hack	Thu Sep 13 17:20:35 2012	(r1015)
+++ /dev/null	00:00:00 1970	(deleted)
@@ -1,38 +0,0 @@
---- configure.in~
-+++ configure.in
-@@ -2855,6 +2855,7 @@ EOF
- #pragma GCC visibility push(hidden)
- #pragma GCC visibility push(default)
- #include <string.h>
-+#include <iterator>
- #pragma GCC visibility pop
- 
- __attribute__ ((visibility ("default"))) void Func() {
-@@ -2863,7 +2864,7 @@ __attribute__ ((visibility ("default"))) void Func() {
- }
- EOF
-                        ac_cv_have_visibility_builtin_bug=no
--                       if ! ${CC-cc} ${CFLAGS} ${DSO_PIC_CFLAGS} ${DSO_LDOPTS} -O2 -S -o conftest.S conftest.c > /dev/null 2>&1 ; then
-+                       if ! ${CXX-c++} ${CXXFLAGS} ${DSO_PIC_CFLAGS} ${DSO_LDOPTS} -O2 -S -o conftest.S conftest.c > /dev/null 2>&1 ; then
-                          ac_cv_have_visibility_builtin_bug=yes
-                        else
-                          if test `grep -c "@PLT" conftest.S` = 0; then
---- js/src/configure.in~
-+++ js/src/configure.in
-@@ -2855,6 +2855,7 @@ EOF
- #pragma GCC visibility push(hidden)
- #pragma GCC visibility push(default)
- #include <string.h>
-+#include <iterator>
- #pragma GCC visibility pop
- 
- __attribute__ ((visibility ("default"))) void Func() {
-@@ -2863,7 +2864,7 @@ __attribute__ ((visibility ("default"))) void Func() {
- }
- EOF
-                        ac_cv_have_visibility_builtin_bug=no
--                       if ! ${CC-cc} ${CFLAGS} ${DSO_PIC_CFLAGS} ${DSO_LDOPTS} -O2 -S -o conftest.S conftest.c > /dev/null 2>&1 ; then
-+                       if ! ${CXX-c++} ${CXXFLAGS} ${DSO_PIC_CFLAGS} ${DSO_LDOPTS} -O2 -S -o conftest.S conftest.c > /dev/null 2>&1 ; then
-                          ac_cv_have_visibility_builtin_bug=yes
-                        else
-                          if test `grep -c "@PLT" conftest.S` = 0; then

Added: trunk/www/firefox-esr/files/patch-clang32-visibility-hack
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ trunk/www/firefox-esr/files/patch-clang32-visibility-hack	Thu Sep 13 17:20:35 2012	(r1016)
@@ -0,0 +1,20 @@
+--- configure.in~
++++ configure.in
+@@ -3230,6 +3230,7 @@ EOF
+                        ac_cv_have_visibility_class_bug,
+                        [cat > conftest.c <<EOF
+ #pragma GCC visibility push(hidden)
++struct TestStruct;
+ struct __attribute__ ((visibility ("default"))) TestStruct {
+   static void Init();
+ };
+--- js/src/configure.in~
++++ js/src/configure.in
+@@ -3230,6 +3230,7 @@ EOF
+                        ac_cv_have_visibility_class_bug,
+                        [cat > conftest.c <<EOF
+ #pragma GCC visibility push(hidden)
++struct TestStruct;
+ struct __attribute__ ((visibility ("default"))) TestStruct {
+   static void Init();
+ };

Deleted: trunk/www/libxul-esr/files/patch-clang32-libc++-visibility-hack
==============================================================================
--- trunk/www/libxul-esr/files/patch-clang32-libc++-visibility-hack	Thu Sep 13 17:20:35 2012	(r1015)
+++ /dev/null	00:00:00 1970	(deleted)
@@ -1,38 +0,0 @@
---- configure.in~
-+++ configure.in
-@@ -2855,6 +2855,7 @@ EOF
- #pragma GCC visibility push(hidden)
- #pragma GCC visibility push(default)
- #include <string.h>
-+#include <iterator>
- #pragma GCC visibility pop
- 
- __attribute__ ((visibility ("default"))) void Func() {
-@@ -2863,7 +2864,7 @@ __attribute__ ((visibility ("default"))) void Func() {
- }
- EOF
-                        ac_cv_have_visibility_builtin_bug=no
--                       if ! ${CC-cc} ${CFLAGS} ${DSO_PIC_CFLAGS} ${DSO_LDOPTS} -O2 -S -o conftest.S conftest.c > /dev/null 2>&1 ; then
-+                       if ! ${CXX-c++} ${CXXFLAGS} ${DSO_PIC_CFLAGS} ${DSO_LDOPTS} -O2 -S -o conftest.S conftest.c > /dev/null 2>&1 ; then
-                          ac_cv_have_visibility_builtin_bug=yes
-                        else
-                          if test `grep -c "@PLT" conftest.S` = 0; then
---- js/src/configure.in~
-+++ js/src/configure.in
-@@ -2855,6 +2855,7 @@ EOF
- #pragma GCC visibility push(hidden)
- #pragma GCC visibility push(default)
- #include <string.h>
-+#include <iterator>
- #pragma GCC visibility pop
- 
- __attribute__ ((visibility ("default"))) void Func() {
-@@ -2863,7 +2864,7 @@ __attribute__ ((visibility ("default"))) void Func() {
- }
- EOF
-                        ac_cv_have_visibility_builtin_bug=no
--                       if ! ${CC-cc} ${CFLAGS} ${DSO_PIC_CFLAGS} ${DSO_LDOPTS} -O2 -S -o conftest.S conftest.c > /dev/null 2>&1 ; then
-+                       if ! ${CXX-c++} ${CXXFLAGS} ${DSO_PIC_CFLAGS} ${DSO_LDOPTS} -O2 -S -o conftest.S conftest.c > /dev/null 2>&1 ; then
-                          ac_cv_have_visibility_builtin_bug=yes
-                        else
-                          if test `grep -c "@PLT" conftest.S` = 0; then

Added: trunk/www/libxul-esr/files/patch-clang32-visibility-hack
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ trunk/www/libxul-esr/files/patch-clang32-visibility-hack	Thu Sep 13 17:20:35 2012	(r1016)
@@ -0,0 +1,20 @@
+--- configure.in~
++++ configure.in
+@@ -3230,6 +3230,7 @@ EOF
+                        ac_cv_have_visibility_class_bug,
+                        [cat > conftest.c <<EOF
+ #pragma GCC visibility push(hidden)
++struct TestStruct;
+ struct __attribute__ ((visibility ("default"))) TestStruct {
+   static void Init();
+ };
+--- js/src/configure.in~
++++ js/src/configure.in
+@@ -3230,6 +3230,7 @@ EOF
+                        ac_cv_have_visibility_class_bug,
+                        [cat > conftest.c <<EOF
+ #pragma GCC visibility push(hidden)
++struct TestStruct;
+ struct __attribute__ ((visibility ("default"))) TestStruct {
+   static void Init();
+ };



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201209131720.q8DHKaXQ020437>