From owner-freebsd-ports@FreeBSD.ORG  Mon Jun 16 18:47:25 2008
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 25D75106567B
	for <freebsd-ports@freebsd.org>; Mon, 16 Jun 2008 18:47:25 +0000 (UTC)
	(envelope-from cyberbotx@cyberbotx.com)
Received: from QMTA05.emeryville.ca.mail.comcast.net
	(qmta05.emeryville.ca.mail.comcast.net [76.96.30.48])
	by mx1.freebsd.org (Postfix) with ESMTP id 0ACFC8FC2D
	for <freebsd-ports@freebsd.org>; Mon, 16 Jun 2008 18:47:24 +0000 (UTC)
	(envelope-from cyberbotx@cyberbotx.com)
Received: from OMTA07.emeryville.ca.mail.comcast.net ([76.96.30.59])
	by QMTA05.emeryville.ca.mail.comcast.net with comcast
	id ebid1Z0091GXsucA50g300; Mon, 16 Jun 2008 18:47:24 +0000
Received: from kirby.cyberbotx.com ([68.43.195.82])
	by OMTA07.emeryville.ca.mail.comcast.net with comcast
	id einM1Z00E1n8LeU8TinPkT; Mon, 16 Jun 2008 18:47:24 +0000
X-Authority-Analysis: v=1.0 c=1 a=djlGcR7NQFkA:10 a=3MMHPmanxm4A:10
	a=z6Hpd0QmOghuzt7LDdwA:9 a=5HwoQ0hL_Jot3lR5CAaWRPWt5BIA:4
	a=QJAqVYndk0IA:10
Message-ID: <4856B539.7040103@cyberbotx.com>
Date: Mon, 16 Jun 2008 14:47:21 -0400
From: Naram Qashat <cyberbotx@cyberbotx.com>
User-Agent: Thunderbird 2.0.0.14 (X11/20080606)
MIME-Version: 1.0
To: =?ISO-8859-1?Q?Rafa=EBl_Carr=E9?= <funman@videolan.org>
References: <4856A283.9050604@cyberbotx.com> <20080616181306.GB24913@zod>
In-Reply-To: <20080616181306.GB24913@zod>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit
Cc: freebsd-ports@freebsd.org
Subject: Re: vlc 0.8.6h failed build on FreeBSD 7.0
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Jun 2008 18:47:25 -0000

Rafaël Carré wrote:
> On Mon, Jun 16, 2008, Naram Qashat wrote:
>> I was trying to build vlc 0.8.6h on my FreeBSD 7.0 system, trying to upgrade 
>> from 0.8.6f.  It gets through most of it but stops around here:
> 
> somehow I failed to reproduce that bug on my setup
> 
> by pure curiosity do you have restrictive CFLAGS in make.conf ?

My CFLAGS are set to -O -pipe

>> Making all in galaktos
>> gmake[5]: Entering directory 
>> `/usr/ports/multimedia/vlc/work/vlc-0.8.6h/modules/visualization/galaktos'
> 
> ..
> 
>> PCM.c:82: error: expected ')' before 'PCMdata'
> 
> this file fails to #include <inttypes.h>
> 
> I removed the previous patch which used short instead of int16_t because I failed to understand what was its purpose.
> 
> 
> 
> I will open a PR with a patch shortly.
> 
> In the meantime you can:
> 
> cd /usr/ports/multimedia/vlc
> make patch
> vi work/vlc-0.8.6h/modules/visualization/galaktos/PCM.c
> :32
> i#include <inttypes.h>
> <ESC>:wq
> make all deinstall reinstall clean
> 
> 
> Thanks for the report
> 

That did indeed fix the build process, thanks for the quick fix.

Naram Qashat