From owner-freebsd-ports@freebsd.org Sat Jan 27 21:05:10 2018 Return-Path: Delivered-To: freebsd-ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9698BEC23CF for ; Sat, 27 Jan 2018 21:05:10 +0000 (UTC) (envelope-from bsdkaffee@gmail.com) Received: from mail-ua0-x22c.google.com (mail-ua0-x22c.google.com [IPv6:2607:f8b0:400c:c08::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3DE0379BDE; Sat, 27 Jan 2018 21:05:10 +0000 (UTC) (envelope-from bsdkaffee@gmail.com) Received: by mail-ua0-x22c.google.com with SMTP id j23so2424646uak.13; Sat, 27 Jan 2018 13:05:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:from:date:message-id:subject:to:cc; bh=1Lo/OHmOgqWprj7kbLS4q68kuwNSY8So4+h20ug0yNg=; b=Qyt3KlgfPSvYjkfQKE6hZ0kBN3evWijORb9kxmrb2W5eTXlecYMXxMFL2EIfKGS6zm 29N8DcBnQzK05Z+7KAGbDnzolbgGtkCpEPcWm4aOYt4UWT6CQbSeio5Fg17frFPmnkE3 Obw89PxSu85A0LJea8BM0w+NfM17VQ4eaMiYs5pBCfjISbtaOm7z+y2hdA0z7DmXYgtd BcGcAr8jcK7lOpBtbftn6JsxXtBbDep4eYLhHRTzC/5kQ0tN+dLC6YPmh3PfSXKOOr32 bQiDWhvHC++IyyBHh5BuPQ1a/IqEzGa8RdTY0VONfigXtK5QQ7Eb5yKwdhljmHufmfQo tbjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:from:date:message-id:subject :to:cc; bh=1Lo/OHmOgqWprj7kbLS4q68kuwNSY8So4+h20ug0yNg=; b=GTZV3niG2fmb7ewPA3drPaNVgf6MdWjOgrBcb7PHfHsVk570uePbgS02xcuBvYS2D2 qf821EjnSTaur7dCBnwOiMWYPeUYSKubPesCqHGOCU7TROMvK6D+HTafEs2LOTRlNpdC S/jJEmQy+Z+rZFV3Y+nlVjxhq7sQ0bMmQs57V7eZ94O6LdPRTZDqIK2fw1VlZkx5be3l 54il0F0hIJccDXdXRJRCRI2Wb+WJjuJSYY2cxVvLUYQaQ7O0GDEW7RPRv1RQ8M7Cukn2 zeTplhFtdpJFvh73rpJ2B+HB36FwybnDOWe7XVCgwmnTX0+dgHDdUVpq79BlB/Uca3VU +vTQ== X-Gm-Message-State: AKwxytcCwqOTVOc2ZZO9uPXqEoNqde8uXWgUjtW1BfXXWYT4rNUu5ugl yI/TSD0lszM7xbUETe2wjjGxE1iOdAerV/py7gaXeA== X-Google-Smtp-Source: AH8x227vM8UIjHozXI5YzYzfq95x78DEkm3Hc9AiwrnDnvnsmHap11Xy8X52QZDUn19qGxWGl+9jJ0VIfa2o2TgyY98= X-Received: by 10.176.83.76 with SMTP id y12mr15721924uay.109.1517087109482; Sat, 27 Jan 2018 13:05:09 -0800 (PST) MIME-Version: 1.0 Sender: bsdkaffee@gmail.com Received: by 10.31.54.212 with HTTP; Sat, 27 Jan 2018 13:05:08 -0800 (PST) From: "Jason E. Hale" Date: Sat, 27 Jan 2018 16:05:08 -0500 X-Google-Sender-Auth: DjPj5062-4FVBVsXciL4Qnhy6IY Message-ID: Subject: 'make clean' seemingly broken with FLAVORS To: FreeBSD Ports Cc: FreeBSD Ports Management Team Content-Type: text/plain; charset="UTF-8" X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Jan 2018 21:05:10 -0000 Just looking for some insight here as I was working on FLAVOR-ifying a port and have run into a problem with the PHB information and the behavior of 'make clean'. According to PHB 7.2 at the top it recommends: Tip: It can help simplify the logic of the Makefile to also define FLAVOR as: FLAVOR?= ${FLAVORS:[1]} I have found setting this to be problematic when it comes to running 'make clean'. If a non-default flavor has been built, the work directory of the non-default flavor is left behind after running the clean target. I think the expected behavior of the clean target is to clean everything. The reason given for setting FLAVOR?= ${FLAVORS:[1]} in an individual port Makefile is to simplify the logic, i.e. using: .if ${FLAVOR} == x11 instead of: .if ${FLAVOR:U} == x11 However, leaving FLAVOR empty in the port Makefile allows for the simpler logic and allows the clean target to work as expected: FLAVOR?= #empty It seems silly to have to set an empty variable, but without it, the only way I could achieve the desired behavior of 'make clean' was to either keep the :U modifier or put the FLAVOR logic after . -Jason (jhale)