From owner-freebsd-current@FreeBSD.ORG  Thu Jun  3 12:23:18 2004
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 2928916A4CE
	for <current@freebsd.org>; Thu,  3 Jun 2004 12:23:18 -0700 (PDT)
Received: from rwcrmhc12.comcast.net (rwcrmhc12.comcast.net [216.148.227.85])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 119D643D31
	for <current@freebsd.org>; Thu,  3 Jun 2004 12:23:18 -0700 (PDT)
	(envelope-from julian@elischer.org)
Received: from interjet.elischer.org ([24.7.73.28])
          by comcast.net (rwcrmhc12) with ESMTP
          id <2004060319231701400nofjge>; Thu, 3 Jun 2004 19:23:17 +0000
Received: from localhost (localhost.elischer.org [127.0.0.1])
	by InterJet.elischer.org (8.9.1a/8.9.1) with ESMTP id MAA67984;
	Thu, 3 Jun 2004 12:23:14 -0700 (PDT)
Date: Thu, 3 Jun 2004 12:23:12 -0700 (PDT)
From: Julian Elischer <julian@elischer.org>
To: Poul-Henning Kamp <phk@phk.freebsd.dk>
In-Reply-To: <10363.1086277953@critter.freebsd.dk>
Message-ID: <Pine.BSF.4.21.0406031220570.51122-100000@InterJet.elischer.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: current@freebsd.org
Subject: Re: [REVIEW/TEST] boot0 changes
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Jun 2004 19:23:18 -0000



On Thu, 3 Jun 2004, Poul-Henning Kamp wrote:

> 
> Ok, now that the dust has settled, I try again.
> 
> Can people please test/review these changes to boot0.  They
> merge closer the SIO and video versions of boot0.
> 
> Thanks in advance.
> 
> 
> Index: boot0.S
> ===================================================================
> RCS file: /home/ncvs/src/sys/boot/i386/boot0/boot0.S,v
> retrieving revision 1.8
> diff -u -r1.8 boot0.S
> --- boot0.S	14 May 2004 20:28:31 -0000	1.8
> +++ boot0.S	3 Jun 2004 15:48:22 -0000
> @@ -95,14 +95,10 @@
>  #ifdef SIO
>  /*
>   * Initialize the serial port.
> - * Must save DX (contains drive number)

if this comment is not actually false, tehn wouldn't it be better
to keep such essoteric info around, maybe bringing them closer together
by ADDING it to the other ones..


>   */
> -		pushw %dx			# Save
> -		xorw %dx,%dx			# Port: COM1
>  		movb COMSPEED,%al		# defined by Makefile
>  		movb $0x00,%ah			# BIOS: Set COM Port
> -		int $0x14			#  Parameters
> -		popw %dx			# Restore
> +		call bioscom
>  #endif /* SIO */
>  /*
>   * Check what flags were loaded with us, specifically, Use a predefined Drive.
> @@ -199,23 +195,21 @@
>  		callw putx			#  item
>  /*
>   * Now that we've printed the drive (if we needed to), display a prompt.
> - * Get ready for the input by noting the time.

ditto.. I don't see th epurpose in removing comments that help one
understand teh code unless they are actually wrong.

Are they wrong?