From owner-cvs-all@FreeBSD.ORG  Wed Jun  6 09:31:11 2007
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@freebsd.org
Delivered-To: cvs-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id E8BE816A400;
	Wed,  6 Jun 2007 09:31:11 +0000 (UTC)
	(envelope-from phk@critter.freebsd.dk)
Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222])
	by mx1.freebsd.org (Postfix) with ESMTP id A3E8113C43E;
	Wed,  6 Jun 2007 09:31:11 +0000 (UTC)
	(envelope-from phk@critter.freebsd.dk)
Received: from critter.freebsd.dk (unknown [192.168.61.3])
	by phk.freebsd.dk (Postfix) with ESMTP id 4A33917380;
	Wed,  6 Jun 2007 09:31:10 +0000 (UTC)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.14.1/8.14.1) with ESMTP id l569VBnN072055;
	Wed, 6 Jun 2007 09:31:12 GMT (envelope-from phk@critter.freebsd.dk)
To: Ceri Davies <ceri@submonkey.net>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Wed, 06 Jun 2007 10:28:37 +0100."
	<20070606092836.GL1834@submonkey.net> 
Date: Wed, 06 Jun 2007 09:31:11 +0000
Message-ID: <72054.1181122271@critter.freebsd.dk>
Sender: phk@critter.freebsd.dk
Cc: src-committers@freebsd.org, cvs-all@freebsd.org, delphij@freebsd.org,
	cvs-src@freebsd.org, "M. Warner Losh" <imp@bsdimp.com>
Subject: Re: cvs commit: src/usr.sbin/sysinstall installUpgrade.c 
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Jun 2007 09:31:12 -0000

In message <20070606092836.GL1834@submonkey.net>, Ceri Davies writes:
>
>--enLffk0M6cffIOOh
>Content-Type: text/plain; charset=us-ascii
>Content-Disposition: inline
>Content-Transfer-Encoding: quoted-printable
>
>On Wed, Jun 06, 2007 at 06:56:42PM +0930, Daniel O'Connor wrote:
>> On Wednesday 06 June 2007 17:10, Ceri Davies wrote:
>> > > Right answer:  Why not read it from sysctl kern.geom.confxml
>> >
>> > That sounds like the right thing to do, but that sysctl returns
>> > nothing on my RELENG_6 system; why would that be?
>>=20
>> Also, parsing it could be problematic :(
>> (XML isn't in sysinstall's limited repertoire)

Please look at how gstat uses a convenient library function to
do just that...

>Well there is kern.geom.conftxt :)

Please don't  That is only a crutch for the old crufty libdisk.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.