From owner-freebsd-bugs@freebsd.org Mon Apr 1 10:49:18 2019 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 356E8155D860 for ; Mon, 1 Apr 2019 10:49:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id AA17669A8A for ; Mon, 1 Apr 2019 10:49:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 67BE4155D85F; Mon, 1 Apr 2019 10:49:17 +0000 (UTC) Delivered-To: bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 53C1B155D85E for ; Mon, 1 Apr 2019 10:49:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DFF0C69A87 for ; Mon, 1 Apr 2019 10:49:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 01ED41575D for ; Mon, 1 Apr 2019 10:49:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x31AnF9x075407 for ; Mon, 1 Apr 2019 10:49:15 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x31AnFTj075406 for bugs@FreeBSD.org; Mon, 1 Apr 2019 10:49:15 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 236930] bsnmpd snmp_target wrong port Date: Mon, 01 Apr 2019 10:49:15 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 11.2-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: t.ermakova@securitycode.ru X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Apr 2019 10:49:18 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D236930 Bug ID: 236930 Summary: bsnmpd snmp_target wrong port Product: Base System Version: 11.2-STABLE Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: bin Assignee: bugs@FreeBSD.org Reporter: t.ermakova@securitycode.ru Created attachment 203290 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D203290&action= =3Dedit A fix-patch We've been trying to use smnp traps via snmp_target module and have encount= ered the situation, when big port number is not set correctly. I've managed to track this down in trap.c. Here is a simple example in c++, showing the problem.=20 vector address =3D {0x07, 0x06, 0x05, 0x04, 0x1a, 0x85}; unsigned short from_code =3D htons(address[4]) << 8 | htons(address[5]) << = 0; unsigned short correct =3D htons(address[4] << 8 | address[5]); cout << ntohs(from_code) << ' ' << ntohs(correct) << endl; The output is: 133 6789 133 is 0x85, while 6789 is the expected result for {0x1a, 0x85}. I'm also attaching the patch that we'll be using in our project, so a reply/review would be great. Thanks in advance. --=20 You are receiving this mail because: You are the assignee for the bug.=