From owner-svn-src-all@FreeBSD.ORG Wed Dec 16 21:33:27 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1EBCE106566C; Wed, 16 Dec 2009 21:33:27 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id C1FCD8FC0A; Wed, 16 Dec 2009 21:33:26 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.3/8.14.1) with ESMTP id nBGLWqCW028024; Wed, 16 Dec 2009 14:32:52 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Wed, 16 Dec 2009 14:33:22 -0700 (MST) Message-Id: <20091216.143322.951491966188790000.imp@bsdimp.com> To: jhb@freebsd.org From: "M. Warner Losh" In-Reply-To: <200912161541.53834.jhb@freebsd.org> References: <200912161717.nBGHHeQZ005541@svn.freebsd.org> <200912161541.53834.jhb@freebsd.org> X-Mailer: Mew version 6.3 on Emacs 22.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r200606 - in head/sys: compat/freebsd32 sys X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Dec 2009 21:33:27 -0000 In message: <200912161541.53834.jhb@freebsd.org> John Baldwin writes: : On Wednesday 16 December 2009 12:17:40 pm Warner Losh wrote: : > Author: imp : > Date: Wed Dec 16 17:17:40 2009 : > New Revision: 200606 : > URL: http://svn.freebsd.org/changeset/base/200606 : > : > Log: : > Fix compiling FREEBSD_COMPAT[4,5,6] without FREEBSD_COMPAT7. : > : > Note: Not sure this is the right way to do compat, but it makes the : > headers consistent with the implementations. : : Please revert. I think this has already been reverted once before. Though : this approach happens to work for the SYSV IPC case because it uses : SYSCALL_MODULE() to register the system calls at runtime (even when compiled : statically into the kernel), it would not work for a COMPAT syscall that did : not use NOSTD. : : From src/UPDATING: : : 20090624: : The ABI of various structures related to the SYSV IPC API have been : changed. As a result, the COMPAT_FREEBSD[456] and COMPAT_43 kernel : options now all require COMPAT_FREEBSD7. Bump __FreeBSD_version to : 800100. Yes. We need a better error than what we get here. I'll revert these generated files and come up with something better. Warner