From owner-freebsd-current  Thu Dec 19 20:35:28 2002
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id ED98037B401; Thu, 19 Dec 2002 20:35:26 -0800 (PST)
Received: from ebb.errno.com (ebb.errno.com [66.127.85.87])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 63D3143EE6; Thu, 19 Dec 2002 20:35:26 -0800 (PST)
	(envelope-from sam@errno.com)
Received: from melange (melange.errno.com [66.127.85.82])
	(authenticated bits=0)
	by ebb.errno.com (8.12.5/8.12.1) with ESMTP id gBK4ZO9i095175
	(version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO);
	Thu, 19 Dec 2002 20:35:24 -0800 (PST)?g
	(envelope-from sam@errno.com)œ
X-Authentication-Warning: ebb.errno.com: Host melange.errno.com [66.127.85.82] claimed to be melange
Message-ID: <0e5401c2a7e1$37149090$52557f42@errno.com>
From: "Sam Leffler" <sam@errno.com>
To: "Hiten Pandya" <hiten@unixdaemons.com>,
	"Darren Reed" <darrenr@reed.wattle.id.au>
Cc: "Hiten Pandya" <hiten@unixdaemons.com>, <current@FreeBSD.ORG>,
	<darrenr@FreeBSD.ORG>
References: <0a6201c2a6f9$42cfd720$52557f42@errno.com> <200212200127.MAA20942@avalon.reed.wattle.id.au> <20021220032930.GA67469@unixdaemons.com>
Subject: Re: PFIL_HOOKS should be made default in 5.0
Date: Thu, 19 Dec 2002 20:35:24 -0800
Organization: Errno Consulting
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
X-Priority: 3
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook Express 5.50.4807.1700
X-MimeOLE: Produced By Microsoft MimeOLE V5.50.4807.1700
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-current.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-current>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-current>
X-Loop: FreeBSD.ORG

> Maybe we should put in the release notes, that:
>
> "PFIL_HOOKS is required for IPFILTER"

The right thing is to force the dependency in the code (I don't think
there's a way to express it to config).  The ipfilter code should probably
have something like

#ifndef PFIL_HOOKS
#error "You must specify PFIL_HOOKS when using ipfilter"
#endif

Unfortunately there's no way that I know to express this if ipfilter is
loaded as a module.

    Sam


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message