From owner-cvs-ports  Fri Jul 10 04:57:54 1998
Return-Path: <owner-cvs-ports>
Received: (from daemon@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id EAA29653
          for cvs-ports-outgoing; Fri, 10 Jul 1998 04:57:54 -0700 (PDT)
          (envelope-from owner-cvs-ports)
Received: from hub.org (hub.org [209.47.148.200])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id EAA29648;
          Fri, 10 Jul 1998 04:57:52 -0700 (PDT)
          (envelope-from scrappy@hub.org)
Received: from localhost (scrappy@localhost) by hub.org (8.8.8/8.7.5) with SMTP id HAA06762; Fri, 10 Jul 1998 07:55:13 -0400 (EDT)
Date: Fri, 10 Jul 1998 07:55:13 -0400 (EDT)
From: The Hermit Hacker <scrappy@hub.org>
To: Thomas Gellekum <tg@ihf.rwth-aachen.de>
cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-ports@FreeBSD.ORG
Subject: Re: cvs commit: ports/audio/kdemultimedia Makefile  ports/audio/kdemultimedia/patches patch-a0 patch-ab patch-ac patch-ag patch-ah
In-Reply-To: <87pvfexdh1.fsf@ghpc6.ihf.rwth-aachen.de>
Message-ID: <Pine.BSF.3.96.980710073806.17148B-100000@hub.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-cvs-ports@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk

On 10 Jul 1998, Thomas Gellekum wrote:

> Andreas Klemm <andreas@klemm.gtn.com> writes:
> 
> > Thomas released a set of patches to Stefan and me. Stefan is a bit
> > overstressed at the moment. I had no time to test as well. So Thomas
> > and you did work for the port at the same time, but you won the
> > "game" by being the first who actually did the commit ;-)
> 
> Sorry to butt in here (again ;-)), but that's not the reason. What got
> me going was the ``removed the patches because it compiles fine
> without them'' in the commit log.
> 
> I tend to assume[1] that Stefan had a good reason to include them,

	The patches that Stefan included were for a previous release of
kdemultimedia...I'm the last person to complain if someone wants to
replace what I did with some patches, I just wanted to get the port
UNBROKEN, which I did.  Now ppl can use the kdemultimedia port, and, from
what I've been able to test here, it works...

	If someone wants to improve the port, by all means, go for it.

	I didn't take someone's port, disagree with the patches they had
for that release and just whip them out...I upgraded a BROKEN port to a
newer release of the software, to which the existing patches were not
appropriate.

> apart from just making the port compile. In this case, they worked
> around a few idiosyncrasies of gmake. 

	And even less appropriate were this the case, or else the
'idiosyncrasies' weren't apparent when I built the newer release of
kdemultimedia...

	Again, I'm not going to cry out if someone changes the port...my
only goal was to get it to a working state, which I did...if someone
doesn't agree with the removal of one of the patches, send me a copy of it
that works with the new port and I put it back in again, its no skin off
my back...