From owner-cvs-all Sun Jan 17 15:51:10 1999 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id PAA22706 for cvs-all-outgoing; Sun, 17 Jan 1999 15:51:10 -0800 (PST) (envelope-from owner-cvs-all@FreeBSD.ORG) Received: from spinner.netplex.com.au (spinner.netplex.com.au [202.12.86.3]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id PAA22696; Sun, 17 Jan 1999 15:51:04 -0800 (PST) (envelope-from peter@netplex.com.au) Received: from spinner.netplex.com.au (localhost [127.0.0.1]) by spinner.netplex.com.au (8.9.2/8.9.2/Netplex) with ESMTP id HAA07539; Mon, 18 Jan 1999 07:50:50 +0800 (WST) (envelope-from peter@spinner.netplex.com.au) Message-Id: <199901172350.HAA07539@spinner.netplex.com.au> X-Mailer: exmh version 2.0.2 2/24/98 To: Bruce Evans cc: cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG Subject: Re: cvs commit: src/sys/net if_tun.c ppp_tty.c src/sys/modules/if_tun Makefile src/sys/modules/if_ppp Makefile In-reply-to: Your message of "Mon, 18 Jan 1999 10:34:38 +1100." <199901172334.KAA02595@godzilla.zeta.org.au> Date: Mon, 18 Jan 1999 07:50:50 +0800 From: Peter Wemm Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk Bruce Evans wrote: > > Modified files: > > sys/net if_tun.c ppp_tty.c > > sys/modules/if_tun Makefile > > sys/modules/if_ppp Makefile > > Log: > > Undo #undef KERNEL hack for vnode.h to avoid vnode_if.h. > > XXX It probably makes sense to have a flag for bsd.kern.mk to avoid these > > rules. > > You mean bsd.kmod.mk. Yep. :-) > VFS_LKM/VFS_KLD does it it for vfs LKM^H^H^HKLDs (KLD is a bad name). I agree, but we can't have two different thigns with the same name. Once the old lkm's are truely gone, then we can choose better terminology for them. > > XXX IO_NDELAY seems to be the main reason for it, when used in a cdevsw > > read or write "flag" context. Perhaps a redundant declaration > > somewhere like sys/conf.h might help remove the need for vnode.h in > > these device drivers in the first place. > > Perhaps just move the definitions. The IO_ flags don't seem to have > anything to do with vnodes. It's the argument for VOP_READ()/VOP_WRITE() etc. It is a vnode flag, but specfs passes it down to the drivers. > Bruce Cheers, -Peter To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message