From nobody Wed Oct 11 06:34:14 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4S53071Zjlz4wyYT; Wed, 11 Oct 2023 06:34:31 +0000 (UTC) (envelope-from rpokala@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4S530713Rmz3VlC; Wed, 11 Oct 2023 06:34:31 +0000 (UTC) (envelope-from rpokala@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1697006071; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GWHjFbc6r0rcsPS26iu1Y7ux6qRNaJYvNKuZDbfTaL8=; b=JdOkdl0xIOMBAi0nmHw3ReYhFpHo462YwX88V4DBaLuYoBr/xOBLRsB5gsPtoOlT4WX+lR T3HDRSVZix6GkuyZuHWnzLC5aBDJ2RdweC1uE1uCB7ZzMzF+rnliGoteqrqBEic5OAamjR dvou/b0FBLXQf0tAuNMMgUs0LZjsBJhu99A4wgE5ofXZM12sAa7w3YILU4y/EFfPaGt9C9 NA88CxYX8CvGWEpXvrdu63dDlChVQVv23dsLLySF+6h4cGlZJiGl8843MKE3IDFFtlRqbL X6ef0mJCZ8ToIMRxtSwPTIrdCrEbXFKTLqbV0VGqjlDWAXJLq/fDBbHaGaZPkA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1697006071; a=rsa-sha256; cv=none; b=WuLFEq+OQnA2OdMjPyw6loMg1NCwVs3Mg1HpchRbFFdYWW9jcoCNk8JMCWPHgcGBHghZEF Q7MlijXnGfcmmZorA2aVql/ImMI7nt9PnJ+QMpurfuSVYzDnms6HqzXcnNqHFUAdac2Z4d wIjvRjFkpuU/WNtgPKBc+S4GHFPQrLOYpIH/FtZ4TS6ist7W2iWVKkbt68CO9rxRAr/pDk fX7Y1sBb//p5DRsA0spKX/e3WXcQUL20xK5gO3Wr8tvNbb0hqH3dNIl9FgUXEEsePAaPDJ tsiKtrABBTPO/r0a+jPcq/cokdpW/gaikFsBp8/oJveMZe1oujrhTCrSsZVt9A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1697006071; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GWHjFbc6r0rcsPS26iu1Y7ux6qRNaJYvNKuZDbfTaL8=; b=bemvfbA8WdFH98KXBDwWLo3awei1E/4qlyE9mSWRwKJm1bRitATPSClt3W1xIjSj4CTE5R /2LQouQiou0rX233u1F6qsn5O1r3vFBapOluhNWbmT/dfmBi/t8FTk1fSIuw/EGA629FL/ NSNKgfbMJoWq9NVMFP6BN0PBabtqYoUbobqupA4bN44CSKFD6pESqM9nUZ8iOPrOG6ApaY 02vI9BCF2ko0/aaqs8W3hUkR4LQIXSIw/uEWK83gryWFvfuwqgFmnd+CWdAv2NAW6B55jv 4jR1a+0lJWpisRComsndp4Cpc2yE8Q5wfoQT6VMbl9BMeyow5EJR+Y3XwqXamQ== Received: from [192.168.0.120] (unknown [103.49.53.150]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: rpokala) by smtp.freebsd.org (Postfix) with ESMTPSA id 4S53046l3dz1VFT; Wed, 11 Oct 2023 06:34:28 +0000 (UTC) (envelope-from rpokala@freebsd.org) User-Agent: Microsoft-MacOutlook/16.77.23091703 Date: Wed, 11 Oct 2023 12:04:14 +0530 Subject: Re: 26103ccba8b7 - main - zfs: enable block cloning by default From: Ravi Pokala To: Alexander Motin , Martin Matuska , , , Message-ID: <71605D3D-27E5-484A-B432-CD18BB924E04@panasas.com> Thread-Topic: 26103ccba8b7 - main - zfs: enable block cloning by default References: <202310102247.39AMlsjX018898@gitrepo.freebsd.org> <2D247230-D189-4A43-85A2-0F2442A9CA6A@panasas.com> In-Reply-To: List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org Mime-version: 1.0 Content-type: text/plain; charset="UTF-8" Content-transfer-encoding: quoted-printable Thanks for the explanation, Alexander. -Ravi (rpokala@) =EF=BB=BF-----Original Message----- From: > on behalf of Alexander Motin > Date: Wednesday, October 11, 2023 at 08:58 To: Ravi Pokala >, Martin = Matuska >, >, >, > Subject: Re: 26103ccba8b7 - main - zfs: enable block cloning by default Hi Ravi, It was disabled because 6 months ago when it was introduced there were=20 some bug reports, and people preferred to stay away rather than debug=20 it. Since then Linux support was added with respective testing and=20 fixing. Several bugs found during FreeBSD testing were addressed, and=20 all the tests are passing clean now. In upstream OpenZFS this feature=20 was never actually disabled, and the release of OpenZFS 2.2.0 including=20 it should be officially tagged nearest days. So we feel it is time for=20 another try. At least until any other issues are reported, there is no=20 reason for it to stay disabled. On 10.10.2023 22:44, Ravi Pokala wrote: > Hi Martin, >=20 > The commit message says "what", not "why". >=20 > Why was block cloning disabled by default before, and why is it being ena= bled now? >=20 > Thanks, >=20 > Ravi (rpokala@) >=20 > =EF=BB=BF-----Original Message----- > From: >> on behalf of Martin Matuska >> > Date: Wednesday, October 11, 2023 at 04:17 > To: >>, >>, <= dev-commits-src-main@FreeBSD.org <= mailto:dev-commits-src-main@FreeBSD.org >> > Subject: git: 26103ccba8b7 - main - zfs: enable block cloning by default >=20 >=20 > The branch main has been updated by mm: >=20 >=20 > URL: https://cgit.FreeBSD.org/src/commit/?id=3D26103ccba8b75038bd8377326852= 4ac814bfa334 >=20 >=20 > commit 26103ccba8b75038bd83773268524ac814bfa334 > Author: Martin Matuska >> > AuthorDate: 2023-10-10 22:43:35 +0000 > Commit: Martin Matuska >> > CommitDate: 2023-10-10 22:43:35 +0000 >=20 >=20 > zfs: enable block cloning by default >=20 >=20 > Discussed with: markj > Reviewed by: mav > Tested by: mm (FreeBSD test suite + OpenZFS test suite) > MFC after: 2 months > Differential Revision: https://reviews.freebsd.org/D41991 > --- > sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vfsops.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 >=20 > diff --git a/sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vfsops.c b/sys= /contrib/openzfs/module/os/freebsd/zfs/zfs_vfsops.c > index 8969fd6a54bd..09e18de81748 100644 > --- a/sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vfsops.c > +++ b/sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vfsops.c > @@ -89,7 +89,7 @@ int zfs_debug_level; > SYSCTL_INT(_vfs_zfs, OID_AUTO, debug, CTLFLAG_RWTUN, &zfs_debug_level, 0, > "Debug level"); >=20 >=20 > -int zfs_bclone_enabled; > +int zfs_bclone_enabled =3D 1; > SYSCTL_INT(_vfs_zfs, OID_AUTO, bclone_enabled, CTLFLAG_RWTUN, > &zfs_bclone_enabled, 0, "Enable block cloning"); >=20 >=20 >=20 >=20 >=20 >=20 --=20 Alexander Motin