From owner-svn-src-head@freebsd.org Sat Aug 6 19:06:32 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0D705BB0A6A; Sat, 6 Aug 2016 19:06:32 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-it0-f48.google.com (mail-it0-f48.google.com [209.85.214.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id CFFC518C6; Sat, 6 Aug 2016 19:06:31 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-it0-f48.google.com with SMTP id u186so46465461ita.0; Sat, 06 Aug 2016 12:06:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :from:date:message-id:subject:to:cc:content-transfer-encoding; bh=vMophArNNX+eWVcekJOUA0tg7KODC+RMgaGP/V6GghE=; b=XEDzwdw0v/uqYcbF6P0cZ55WNVJGlXawjYlfTXlG4mLoyb6Hkr0SUdr/iBBgOQYDly cm3vO91yErXkJJjRzHcEQCflXzahMIigCzpT7qnh12vx2s111CDEu1tsRX0nCbwDi5/A 5sqs/cjpbb+bjKPtar4PpffOoqpPMXdsRNm9HUEw4QJw6PrT3exnqTEh6b3kXhVYg7eG XAbetOGT1fLWcGC4wZ6NBvO8yc1LLUO/pjLTpECD1bEpOI6UimukBDqRUhW6eIAKEg3J IlyjjNP9sBJGZGo/6ybOnrKeVrW7H01B3QxoV7qFi9nkNPh2Y1V8kfsgUTkwDwOG67jP DP+A== X-Gm-Message-State: AEkoouuxb+mlciJWAFby1awFhNFpFxXGBt4kKzv9N6oO8c6JxARUL1aPpu401PdNBk7BqQ== X-Received: by 10.36.139.2 with SMTP id g2mr10569221ite.75.1470510384761; Sat, 06 Aug 2016 12:06:24 -0700 (PDT) Received: from mail-it0-f50.google.com (mail-it0-f50.google.com. [209.85.214.50]) by smtp.gmail.com with ESMTPSA id y194sm10749832iod.17.2016.08.06.12.06.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 06 Aug 2016 12:06:24 -0700 (PDT) Received: by mail-it0-f50.google.com with SMTP id f6so51572492ith.0; Sat, 06 Aug 2016 12:06:23 -0700 (PDT) X-Received: by 10.36.76.16 with SMTP id a16mr10705405itb.86.1470510383072; Sat, 06 Aug 2016 12:06:23 -0700 (PDT) MIME-Version: 1.0 Reply-To: cem@freebsd.org Received: by 10.36.122.208 with HTTP; Sat, 6 Aug 2016 12:06:22 -0700 (PDT) In-Reply-To: <201608061727.u76HR7TQ000766@repo.freebsd.org> References: <201608061727.u76HR7TQ000766@repo.freebsd.org> From: Conrad Meyer Date: Sat, 6 Aug 2016 12:06:22 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r303801 - head/share/man/man3 To: Benjamin Kaduk Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Aug 2016 19:06:32 -0000 Hey Benjamin, The submitter notes that this wider change isn't quite right in https://reviews.freebsd.org/D7428 =E2=80=94 LIST_SWAP and TAILQ_SWAP both n= eed the "entry" parameter. Best, Conrad On Sat, Aug 6, 2016 at 10:27 AM, Benjamin Kaduk wrote: > Author: bjk (doc committer) > Date: Sat Aug 6 17:27:07 2016 > New Revision: 303801 > URL: https://svnweb.freebsd.org/changeset/base/303801 > > Log: > Correct the documentation of the 'type' parameter for the _SWAP > macros from sys/queue.h > > Submitted by: akshay1994.leo_gmail.com (for STAILQ) > Differential Revision: https://reviews.freebsd.org/D7428 > > Modified: > head/share/man/man3/queue.3 > > Modified: head/share/man/man3/queue.3 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/share/man/man3/queue.3 Sat Aug 6 17:24:35 2016 (r303800) > +++ head/share/man/man3/queue.3 Sat Aug 6 17:27:07 2016 (r303801) > @@ -141,7 +141,7 @@ lists and tail queues > .Fn SLIST_REMOVE "SLIST_HEAD *head" "TYPE *elm" "TYPE" "SLIST_ENTRY NAME= " > .Fn SLIST_REMOVE_AFTER "TYPE *elm" "SLIST_ENTRY NAME" > .Fn SLIST_REMOVE_HEAD "SLIST_HEAD *head" "SLIST_ENTRY NAME" > -.Fn SLIST_SWAP "SLIST_HEAD *head1" "SLIST_HEAD *head2" "SLIST_ENTRY NAME= " > +.Fn SLIST_SWAP "SLIST_HEAD *head1" "SLIST_HEAD *head2" "TYPE" > .\" > .Fn STAILQ_CLASS_ENTRY "CLASSTYPE" > .Fn STAILQ_CLASS_HEAD "HEADNAME" "CLASSTYPE" > @@ -164,7 +164,7 @@ lists and tail queues > .Fn STAILQ_REMOVE "STAILQ_HEAD *head" "TYPE *elm" "TYPE" "STAILQ_ENTRY N= AME" > .Fn STAILQ_REMOVE_AFTER "STAILQ_HEAD *head" "TYPE *elm" "STAILQ_ENTRY NA= ME" > .Fn STAILQ_REMOVE_HEAD "STAILQ_HEAD *head" "STAILQ_ENTRY NAME" > -.Fn STAILQ_SWAP "STAILQ_HEAD *head1" "STAILQ_HEAD *head2" "STAILQ_ENTRY = NAME" > +.Fn STAILQ_SWAP "STAILQ_HEAD *head1" "STAILQ_HEAD *head2" "TYPE" > .\" > .Fn LIST_CLASS_ENTRY "CLASSTYPE" > .Fn LIST_CLASS_HEAD "HEADNAME" "CLASSTYPE" > @@ -184,7 +184,7 @@ lists and tail queues > .Fn LIST_NEXT "TYPE *elm" "LIST_ENTRY NAME" > .Fn LIST_PREV "TYPE *elm" "LIST_HEAD *head" "TYPE" "LIST_ENTRY NAME" > .Fn LIST_REMOVE "TYPE *elm" "LIST_ENTRY NAME" > -.Fn LIST_SWAP "LIST_HEAD *head1" "LIST_HEAD *head2" "TYPE" "LIST_ENTRY N= AME" > +.Fn LIST_SWAP "LIST_HEAD *head1" "LIST_HEAD *head2" "TYPE" > .\" > .Fn TAILQ_CLASS_ENTRY "CLASSTYPE" > .Fn TAILQ_CLASS_HEAD "HEADNAME" "CLASSTYPE" > @@ -211,7 +211,7 @@ lists and tail queues > .Fn TAILQ_NEXT "TYPE *elm" "TAILQ_ENTRY NAME" > .Fn TAILQ_PREV "TYPE *elm" "HEADNAME" "TAILQ_ENTRY NAME" > .Fn TAILQ_REMOVE "TAILQ_HEAD *head" "TYPE *elm" "TAILQ_ENTRY NAME" > -.Fn TAILQ_SWAP "TAILQ_HEAD *head1" "TAILQ_HEAD *head2" "TYPE" "TAILQ_ENT= RY NAME" > +.Fn TAILQ_SWAP "TAILQ_HEAD *head1" "TAILQ_HEAD *head2" "TYPE" > .\" > .Sh DESCRIPTION > These macros define and operate on four types of data structures which >