From owner-svn-src-projects@freebsd.org Wed Feb 13 15:21:24 2019 Return-Path: Delivered-To: svn-src-projects@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4DB9214CE9B2 for ; Wed, 13 Feb 2019 15:21:24 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 9E6A18F1EE; Wed, 13 Feb 2019 15:21:22 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id x1DFLJMW082037; Wed, 13 Feb 2019 07:21:19 -0800 (PST) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id x1DFLJqT082036; Wed, 13 Feb 2019 07:21:19 -0800 (PST) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201902131521.x1DFLJqT082036@pdx.rh.CN85.dnsmgr.net> Subject: Re: svn commit: r344087 - in projects/import-googletest-1.8.1/lib/googletest: gmock/tests gtest/tests In-Reply-To: <7F4DB347-CD49-4A09-A360-7DBAB33EEBC6@gmail.com> To: Enji Cooper Date: Wed, 13 Feb 2019 07:21:19 -0800 (PST) CC: rgrimes@freebsd.org, Enji Cooper , src-committers@freebsd.org, svn-src-projects@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 9E6A18F1EE X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.94 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.998,0]; NEURAL_HAM_SHORT(-0.95)[-0.947,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Feb 2019 15:21:24 -0000 > On Feb 13, 2019, at 06:42, Rodney W. Grimes wrote: > > >> On Feb 13, 2019, at 06:26, Rodney W. Grimes wrote: > >> > >>>> Author: ngie > >>>> Date: Wed Feb 13 05:41:04 2019 > >>>> New Revision: 344087 > >>>> URL: https://svnweb.freebsd.org/changeset/base/344087 > >>>> > >>>> Log: > >>>> Compile the tests without -Werror for now > >>>> > >>>> I'm working on resolving the issue upstream on github > >>>> > >>>> Modified: > >>>> projects/import-googletest-1.8.1/lib/googletest/gmock/tests/Makefile > >>>> projects/import-googletest-1.8.1/lib/googletest/gtest/tests/Makefile > >>> > >>> Are we going to have to live with this project name of > >>> import-googletest-1.8.1 long term, or is this just a > >>> stepping stone? > >> > >> It?s a short lived project. I didn?t realize in the last year and a > >> half that branch names had formalized into something else, especially > >> since GUIDELINES.txt doesn?t state a naming convention. > > > > I do not know that they have formalized in any way. But as long > > as it is shorted lived it really does not matter much. > > > > Please do be careful when choosing a vendor/ directory name > > if that is where this is headed, 'import' and '1.8.1' are > > probably not wanted there at all, just googletest. > > brooks reviewed my initial import into vendor to ensure that the > naming/structure was correct: ^/vendor/google/googletest/dist -> > ^/vendor/google/googletest/1.8.1 (for the release branch, given > that the initial import was 1.8.1). > > I?ve been following similar conventions before in the past > other projects I?ve imported. Given that this is the first of a > handful of google projects that will be imported, I don?t > understand why there?s an issue with this naming convention. There is no issue here, I did not raise an issue, I just asked if that project was a short term thing, and wanted to make sure that the long name was not copied into the vendor area, which you have not, you have broken the long name up into its components as directories as is the norm. > -Enji -- Rod Grimes rgrimes@freebsd.org