Date: Tue, 11 Dec 2012 03:02:51 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Tom Judge <tj@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r308491 - in head: . textproc textproc/elasticsearch textproc/elasticsearch/files Message-ID: <20121211030251.GB37200@FreeBSD.org> In-Reply-To: <201212082048.qB8KmfsZ013488@svn.freebsd.org> References: <201212082048.qB8KmfsZ013488@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Dec 08, 2012 at 08:48:41PM +0000, Tom Judge wrote: > New Revision: 308491 > URL: http://svnweb.freebsd.org/changeset/ports/308491 > > Log: > Elasticsearch aims to be a Distributed, RESTful, Search Engine built on > top of Apache Lucene. > +# Created by: Tom Judge <tj@FreeBSD.org> Wrong header format (should have used space, not a tab here). Was fixed in r308605 by bapt@. > +MAINTAINER= tj@FreeBSD.org > +COMMENT= A full-text search engine for Java COMMENT should not begin with an article. > +JAVA_VERSION= 1.5+ I thought 1.5 would be deprecated soon. Again, fixed in r308605. > +DOCS= LICENSE.txt \ Any reason to install LICENSE.txt file for a standard license? > +post-patch: > + ${SED} -i .bak -e "s|%%PREFIX%%|${PREFIX}|g" ${WRKSRC}/config/elasticsearch.yml What's wrong with REINPLACE_CMD? Is there necessity for global modifier in regexp? > + ${MKDIR} ${PREFIX}/lib/elasticsearch > ... > + ${MKDIR} ${PREFIX}/lib/elasticsearch/sigar Usually MKDIR's are muted... Also, first statement is not required as MKDIR implies -p. > + @${MKDIR} ${DOCSDIR} ... Like you do here. ;-) ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121211030251.GB37200>