Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 20 May 2021 00:40:00 +0000
From:      bugzilla-noreply@freebsd.org
To:        ports-bugs@FreeBSD.org
Subject:   [Bug 255974] New port: www/civetweb Embedded C/C++ web server
Message-ID:  <bug-255974-7788-RNMWLvzouL@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-255974-7788@https.bugs.freebsd.org/bugzilla/>
References:  <bug-255974-7788@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D255974

Daniel Engberg <daniel.engberg.lists@pyret.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |daniel.engberg.lists@pyret.
                   |                            |net

--- Comment #1 from Daniel Engberg <daniel.engberg.lists@pyret.net> ---
Hi,

You should use DISTVERSION as Porters Handbook instructions you to.
https://docs.freebsd.org/en/books/porters-handbook/book.html#makefile-maste=
r_sites-github-description

DISTVERSIONPREFIX should be set before DISTVERSION - See link above

Please define LICENSE_FILE
https://docs.freebsd.org/en/books/porters-handbook/book.html#licenses

USE_LDCONFIG is missing
https://docs.freebsd.org/en/books/porters-handbook/book.html#porting-shlibs

Have a look at section "6.5.4. Using cmake" in Porters Handbook, CMAKE_ON /
CMAKE_OFF should work instead of using CMAKE_ARGS

Looking at the CMake-file these options doesn't seem to be enabled by defau=
lt,
does it make sense to have these enabled especially since they won't pull in
any other deps?
CIVETWEB_ENABLE_IPV6 , CIVETWEB_ENABLE_ZLIB , CIVETWEB_ENABLE_SSL ?

You don't need to define GH_ACCOUNT
https://docs.freebsd.org/en/books/porters-handbook/book.html#makefile-maste=
r_sites-github-description

USE_GITHUB needs to be relocated in the Makefile

Give portlint and/or portfmt a spin :-)

Does it build using poudriere?

Thanks for your submission

Best regards,
Daniel

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-255974-7788-RNMWLvzouL>