From owner-freebsd-fs@FreeBSD.ORG Mon May 17 15:36:42 2010 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0C7C41065678; Mon, 17 May 2010 15:36:42 +0000 (UTC) (envelope-from alex.bakhtin@gmail.com) Received: from mail-fx0-f54.google.com (mail-fx0-f54.google.com [209.85.161.54]) by mx1.freebsd.org (Postfix) with ESMTP id 434718FC1D; Mon, 17 May 2010 15:36:40 +0000 (UTC) Received: by fxm19 with SMTP id 19so1093653fxm.13 for ; Mon, 17 May 2010 08:36:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=s6mO/6cTcDHdEDtJuLGwJCAdUv7kscjsuHbH4HIkXzY=; b=ceFfim9UHXQDD3Cc/XyoGvGIHCxpSgaOLdjWlRZMZuMeAjyDw5Ryhcf18fxC/G5Guw euCWBriA1hoKCCG9gkmvdFiW2Hyx6wW7R2Gx6R4+6c4Awi9uglavhtjL4ZB/DrcVwmF7 gKpAeIO5gDWe2TI8jcRNM8BQ5bGj75Z+z8+HE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=hEt1OLQKqjFXKjfvHip82tVLkiovsBar14vDlUhn+UKj23P0VVj+X5gIjlO4LMHOL1 UYDv+8JLuZS9fIjfKx3jpw7o9VLXJCO2wPXI8Z9V9Ws+KJtPGFM1UOCFpL/+RRszv+nN AJVSwFzHvqkR9zJQAqI+ZBJ0RTbfHw8BbWUqM= MIME-Version: 1.0 Received: by 10.204.33.194 with SMTP id i2mr10200bkd.140.1274110599812; Mon, 17 May 2010 08:36:39 -0700 (PDT) Received: by 10.204.71.139 with HTTP; Mon, 17 May 2010 08:36:39 -0700 (PDT) In-Reply-To: <201005130934.o4D9YiJL039462@freefall.freebsd.org> References: <201005130934.o4D9YiJL039462@freefall.freebsd.org> Date: Mon, 17 May 2010 19:36:39 +0400 Message-ID: From: Alex Bakhtin To: pjd@freebsd.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-fs@freebsd.org, bug-followup@freebsd.org Subject: Re: kern/145339: [zfs] deadlock after detaching block device from raidz pool X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 May 2010 15:36:42 -0000 Pawel, I tested your patch in the following zfs configuration (all on 5x2TB WD20EARS drivers): 1. raidz1 on top of physical disks. 2. raidz1 on top of geli 3. raidz2 on top of physical disks. In all three cases it seems that the problem was fixed - I can't crash zfs in vdev_geom when unplugging the disk. Unfortunately, 3 times I got a deadlock in zfs after plugging vdevs back under load. It happens several seconds after zpool online command. I'm not 100 percent sure that deadlocks are related to this patch, but... I'm going to make some additional testing with patched and not patched kernels. 2010/5/13 : > Synopsis: [zfs] deadlock after detaching block device from raidz pool > > State-Changed-From-To: open->feedback > State-Changed-By: pjd > State-Changed-When: czw 13 maj 2010 09:33:20 UTC > State-Changed-Why: > Could you try this patch: > > =A0 =A0 =A0 =A0http://people.freebsd.org/~pjd/patches/vdev_geom.c.3.patch > > It is against most recent HEAD. If it is rejected on 8-STABLE, just grab > entire vdev_geom.c from HEAD and patch this. > > > Responsible-Changed-From-To: freebsd-fs->pjd > Responsible-Changed-By: pjd > Responsible-Changed-When: czw 13 maj 2010 09:33:20 UTC > Responsible-Changed-Why: > I'll take this one. > > http://www.freebsd.org/cgi/query-pr.cgi?pr=3D145339 >