Date: Sat, 19 Sep 2015 11:39:29 -0600 From: Ian Lepore <ian@freebsd.org> To: George Neville-Neil <gnn@neville-neil.com> Cc: Hans Petter Selasky <hps@selasky.org>, David Chisnall <theraven@FreeBSD.org>, Gleb Smirnoff <glebius@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r287780 - in head: share/man/man9 sys/kern sys/sys Message-ID: <1442684369.1224.179.camel@freebsd.org> In-Reply-To: <64D8263B-1F5D-40E5-994C-479C39B69DC9@neville-neil.com> References: <201509141052.t8EAqRWf008293@repo.freebsd.org> <20150916220559.GS1023@FreeBSD.org> <55FA69BD.10507@selasky.org> <0952027A-5276-487D-99B8-74747B0EEF5D@FreeBSD.org> <55FD23C5.5010008@selasky.org> <64D8263B-1F5D-40E5-994C-479C39B69DC9@neville-neil.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 2015-09-19 at 12:37 -0400, George Neville-Neil wrote: > > On 19 Sep 2015, at 4:58, Hans Petter Selasky wrote: > > > On 09/17/15 11:07, David Chisnall wrote: > >> I would expect*anyone* making a change like this to have both the > >> design and code reviewed for sanity checking. > > > > Please add an entry to MAINTAINERS for those parts of the kernel which > > require this strict reviews. > > > > This is not about MAINTAINERS, this is about review. Several commenters > on this thread > have pointed out that this code, which is part of a core component of > the system, was committed > without review. Please back this out and then put whatever you propose > to do up in the reviews.freebsd.org > system. > > Best, > George > > I'm afraid this message can be interpetted as "reviews are now mandatory for a 'core component of the system' (whatever that means)". If so, this would be a Big Change from the last thing I heard about code reviews, which was basically: as much as some people would like it to be so, they are not mandatory. Another way to interpret this might be "While code reviews are not generally mandatory, if multiple developers request a review of some change, even after the fact, then that should (must?) be honored." Could we please get some clarification (officially, from core) about this? And yes I know that certain areas of the system, such as crypto-related code, have always been treated differently, but that has never involved a definition as meaningless and vague as "a core component of the system". -- Ian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1442684369.1224.179.camel>