From owner-svn-src-head@freebsd.org Sat Nov 14 22:34:37 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9CE75467776 for ; Sat, 14 Nov 2020 22:34:37 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qt1-x82a.google.com (mail-qt1-x82a.google.com [IPv6:2607:f8b0:4864:20::82a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CYVWd3rjmz4W6d for ; Sat, 14 Nov 2020 22:34:37 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qt1-x82a.google.com with SMTP id 3so10075280qtx.3 for ; Sat, 14 Nov 2020 14:34:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kFlydka7vJ9MGC2Wd/WHDVHNr6lHFmzKL9lcNfPzrec=; b=Kn1vqWd7qPiiTNpgcMaci3Hh2DFed+dK6oFISrIPDU8iBJSQTlFAUqwrnbOhFLz1yW 564v66kSDJ8tjd6NTn4YYq8dLiQCbm1gVCPHEnYyo0SuqE1jXIjTD7215EMX+sNNPOxu XmShhsJUUywlBxvacS2trR4xkkKwKLdusjlaEXFHdhDY0FlNUF4jf5ZenJt+T65SFO43 nadK7yMPjLHXXiQhqx72A9q4VwbxuuaIpgCBHiOxP2xlx3zmNM3CDO7jUFaAfNzwkzaz ++Ti1pCLUaLmq2+6ptBSjwJs+8+B3b4W0H2lGGtzDyKJctu7qRlGGjIwLyjhfu+GS3Hf 96SQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kFlydka7vJ9MGC2Wd/WHDVHNr6lHFmzKL9lcNfPzrec=; b=m2ma7OnDQ/loqvk5POhIhjKpYy5Q//XUAScterwiFYSnw3C2NP9AP7wiI+gqA/ov/8 NClmxiSEOuUPJl0PHVy/2EWOY+VHuWTUWILLBqCQ9UugwVTX1Phe88gkLL+CsG4AwXQf je9phgaRXmfG6pgj0Wj/xRbsm6h9DVLXVfDmwMv1Mbsjv5Vg490g+uYc98+kXjj+tZOI N5bat/Glf3mHexvmHAaNDb1n/PtjdDSME7q+E45L6lA2AHipVWS2b/W4BN9Fu+km9SZB Kq0FB+sNZlLP8+H3yGY713MckZ/CPE93L6Fpl2HROuN3BHGVISmIE7pCODwcHVeI/3yS D3NA== X-Gm-Message-State: AOAM531iFOOQfL8ulv48LhOHdyuTYqNBdyhfvu4vHiugyXyqvjN1y54F pQuR0Rjq5uGc6l441monh8TqmT9MGBrWUGBG0cx4JQ== X-Google-Smtp-Source: ABdhPJyDlfbLqHGNqiwTcY+Z0XNYKrJUkmIywp6xCEb2Uu4YSDpX5zvFPeAc1m9y6c1wo++ee2twL23X8p1DuRjTZvA= X-Received: by 2002:ac8:5351:: with SMTP id d17mr8174761qto.235.1605393276390; Sat, 14 Nov 2020 14:34:36 -0800 (PST) MIME-Version: 1.0 References: <202011141920.0AEJKbpO050396@repo.freebsd.org> <20201114205036.tnxvwarsddmu4shz@mutt-hbsd> <20201114205355.j2ejnhouipjr6yhk@mutt-hbsd> In-Reply-To: From: Warner Losh Date: Sat, 14 Nov 2020 15:34:25 -0700 Message-ID: Subject: Re: svn commit: r367692 - head/sys/sys To: Mateusz Guzik Cc: Shawn Webb , src-committers , svn-src-all , svn-src-head X-Rspamd-Queue-Id: 4CYVWd3rjmz4W6d X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Nov 2020 22:34:37 -0000 true, but a version bump forces that and versions are cheap enough... Warner On Sat, Nov 14, 2020 at 1:58 PM Mateusz Guzik wrote: > you are expected to recompile all your kernel modules every time you > update head > > On 11/14/20, Shawn Webb wrote: > > Are there any kernel modules (in base, in ports, or out-of-both-trees) > > that access struct ucred? > > > > On Sat, Nov 14, 2020 at 09:51:47PM +0100, Mateusz Guzik wrote: > >> I don't think so, it does not change any APIs > >> > >> On 11/14/20, Shawn Webb wrote: > >> > On Sat, Nov 14, 2020 at 07:20:37PM +0000, Mateusz Guzik wrote: > >> >> Author: mjg > >> >> Date: Sat Nov 14 19:20:37 2020 > >> >> New Revision: 367692 > >> >> URL: https://svnweb.freebsd.org/changeset/base/367692 > >> >> > >> >> Log: > >> >> cred: reorder cr_audit to be closer to the lock > >> >> > >> >> This makes cr_uid avoid sharing. > >> >> > >> >> Modified: > >> >> head/sys/sys/ucred.h > >> >> > >> >> Modified: head/sys/sys/ucred.h > >> >> > ============================================================================== > >> >> --- head/sys/sys/ucred.h Sat Nov 14 19:19:27 2020 (r367691) > >> >> +++ head/sys/sys/ucred.h Sat Nov 14 19:20:37 2020 (r367692) > >> >> @@ -63,6 +63,7 @@ struct ucred { > >> >> struct mtx cr_mtx; > >> >> u_int cr_ref; /* (c) reference count */ > >> >> u_int cr_users; /* (c) proc + thread using this > cred */ > >> >> + struct auditinfo_addr cr_audit; /* Audit properties. */ > >> >> #define cr_startcopy cr_uid > >> >> uid_t cr_uid; /* effective user id */ > >> >> uid_t cr_ruid; /* real user id */ > >> >> @@ -78,7 +79,6 @@ struct ucred { > >> >> void *cr_pspare2[2]; /* general use 2 */ > >> >> #define cr_endcopy cr_label > >> >> struct label *cr_label; /* MAC label */ > >> >> - struct auditinfo_addr cr_audit; /* Audit properties. */ > >> >> gid_t *cr_groups; /* groups */ > >> >> int cr_agroups; /* Available groups */ > >> >> gid_t cr_smallgroups[XU_NGROUPS]; /* storage for small > groups */ > >> > > >> > Hey Mateusz, > >> > > >> > Since this changes KBI, does __FreeBSD_version need bumping? > >> > > >> > Thanks, > >> > > >> > -- > >> > Shawn Webb > >> > Cofounder / Security Engineer > >> > HardenedBSD > >> > > >> > GPG Key ID: 0xFF2E67A277F8E1FA > >> > GPG Key Fingerprint: D206 BB45 15E0 9C49 0CF9 3633 C85B 0AF8 AB23 > 0FB2 > >> > > https://git-01.md.hardenedbsd.org/HardenedBSD/pubkeys/src/branch/master/Shawn_Webb/03A4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc > >> > > >> > >> > >> -- > >> Mateusz Guzik > > > > -- > > Shawn Webb > > Cofounder / Security Engineer > > HardenedBSD > > > > GPG Key ID: 0xFF2E67A277F8E1FA > > GPG Key Fingerprint: D206 BB45 15E0 9C49 0CF9 3633 C85B 0AF8 AB23 0FB2 > > > https://git-01.md.hardenedbsd.org/HardenedBSD/pubkeys/src/branch/master/Shawn_Webb/03A4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc > > > > > -- > Mateusz Guzik >