From owner-p4-projects@FreeBSD.ORG  Thu Oct 23 16:45:26 2003
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 4AF5F16A4C0; Thu, 23 Oct 2003 16:45:26 -0700 (PDT)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 2729716A4B3
	for <perforce@freebsd.org>; Thu, 23 Oct 2003 16:45:26 -0700 (PDT)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id A43DA43F75
	for <perforce@freebsd.org>; Thu, 23 Oct 2003 16:45:25 -0700 (PDT)
	(envelope-from sam@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.12.9/8.12.9) with ESMTP id h9NNjPXJ096461
	for <perforce@freebsd.org>; Thu, 23 Oct 2003 16:45:25 -0700 (PDT)
	(envelope-from sam@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.12.9/8.12.9/Submit) id h9NNjPka096458
	for perforce@freebsd.org; Thu, 23 Oct 2003 16:45:25 -0700 (PDT)
	(envelope-from sam@freebsd.org)
Date: Thu, 23 Oct 2003 16:45:25 -0700 (PDT)
Message-Id: <200310232345.h9NNjPka096458@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	sam@freebsd.org using -f
From: Sam Leffler <sam@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Subject: PERFORCE change 40350 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 23 Oct 2003 23:45:26 -0000

http://perforce.freebsd.org/chv.cgi?CH=40350

Change 40350 by sam@sam_ebb on 2003/10/23 16:44:27

	socket_send may be entered from a callout and so not have
	Giant; must grab Giant to protect sbappendaddr until sockets
	are locked

Affected files ...

.. //depot/projects/netperf/sys/netinet/ip_mroute.c#15 edit

Differences ...

==== //depot/projects/netperf/sys/netinet/ip_mroute.c#15 (text+ko) ====

@@ -1287,10 +1287,13 @@
 socket_send(struct socket *s, struct mbuf *mm, struct sockaddr_in *src)
 {
     if (s) {
+	mtx_lock(&Giant);	/* XXX no socket locking */
 	if (sbappendaddr(&s->so_rcv, (struct sockaddr *)src, mm, NULL) != 0) {
 	    sorwakeup(s);
+	    mtx_unlock(&Giant);	/* XXX */
 	    return 0;
 	}
+        mtx_unlock(&Giant);	/* XXX */
     }
     m_freem(mm);
     return -1;