From owner-svn-src-all@FreeBSD.ORG Sun Apr 5 18:54:29 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id BCCF3C15; Sun, 5 Apr 2015 18:54:29 +0000 (UTC) Received: from dchagin.static.corbina.net (dchagin.static.corbina.ru [78.107.232.239]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "dchagin.static.corbina.net", Issuer "dchagin.static.corbina.net" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 43774F2D; Sun, 5 Apr 2015 18:54:28 +0000 (UTC) Received: from dchagin.static.corbina.net (localhost [127.0.0.1]) by dchagin.static.corbina.net (8.14.9/8.14.9) with ESMTP id t35IsJa7046101 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sun, 5 Apr 2015 21:54:20 +0300 (MSK) (envelope-from dchagin@dchagin.static.corbina.net) Received: (from dchagin@localhost) by dchagin.static.corbina.net (8.14.9/8.14.9/Submit) id t35IsJN2046100; Sun, 5 Apr 2015 21:54:19 +0300 (MSK) (envelope-from dchagin) Date: Sun, 5 Apr 2015 21:54:19 +0300 From: Chagin Dmitry To: Mateusz Guzik Subject: Re: svn commit: r281113 - head/sys/vm Message-ID: <20150405185419.GA46092@dchagin.static.corbina.net> References: <201504051825.t35IPO7t078390@svn.freebsd.org> <20150405183947.GA24293@dft-labs.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150405183947.GA24293@dft-labs.eu> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Apr 2015 18:54:29 -0000 On Sun, Apr 05, 2015 at 08:39:47PM +0200, Mateusz Guzik wrote: > On Sun, Apr 05, 2015 at 06:25:24PM +0000, Dmitry Chagin wrote: > > Author: dchagin > > Date: Sun Apr 5 18:25:23 2015 > > New Revision: 281113 > > URL: https://svnweb.freebsd.org/changeset/base/281113 > > > > Log: > > Fix wrong kassert msg in uma. > > > > PR: 199172 > > Submitted by: luke.tw gmail com > > MFC after: 1 week > > > > Modified: > > head/sys/vm/uma_core.c > > > > Modified: head/sys/vm/uma_core.c > > ============================================================================== > > --- head/sys/vm/uma_core.c Sun Apr 5 17:09:58 2015 (r281112) > > +++ head/sys/vm/uma_core.c Sun Apr 5 18:25:23 2015 (r281113) > > @@ -3060,7 +3060,7 @@ uma_zone_set_fini(uma_zone_t zone, uma_f > > uma_keg_t keg; > > > > keg = zone_first_keg(zone); > > - KASSERT(keg != NULL, ("uma_zone_set_init: Invalid zone type")); > > + KASSERT(keg != NULL, ("uma_zone_set_fini: Invalid zone type")); > > KEG_LOCK(keg); > > KASSERT(keg->uk_pages == 0, > > ("uma_zone_set_fini on non-empty keg")); > > @@ -3100,7 +3100,7 @@ uma_zone_set_freef(uma_zone_t zone, uma_ > > uma_keg_t keg; > > > > keg = zone_first_keg(zone); > > - KASSERT(keg != NULL, ("uma_zone_set_init: Invalid zone type")); > > + KASSERT(keg != NULL, ("uma_zone_set_freef: Invalid zone type")); > > KEG_LOCK(keg); > > keg->uk_freef = freef; > > KEG_UNLOCK(keg); > > > > This seems to be a recurring problem (go figure). > > Was __func__ usage flamed over? > > I really think that linux's oops-like dump would be of great help here. > It includes file + line info along with register dump which alone can > give sufficient hints in several cases. > finally, kassert prints backtrace. also feel free to set debug.kassert.do_kdb. -- Have fun! chd