From owner-freebsd-arch@FreeBSD.ORG  Fri Jan 13 17:52:12 2006
Return-Path: <owner-freebsd-arch@FreeBSD.ORG>
X-Original-To: arch@FreeBSD.org
Delivered-To: freebsd-arch@FreeBSD.ORG
Received: by hub.freebsd.org (Postfix, from userid 1035)
	id 551AC16A420; Fri, 13 Jan 2006 17:52:12 +0000 (GMT)
Date: Fri, 13 Jan 2006 17:52:12 +0000
From: Xin LI <delphij@FreeBSD.org>
To: Gleb Smirnoff <glebius@FreeBSD.org>
Message-ID: <20060113175212.GA4170@hub.freebsd.org>
References: <20060113170552.GF83922@FreeBSD.org>
	<20060113171759.GA1255@hub.freebsd.org>
	<20060113172049.GG83922@cell.sick.ru>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20060113172049.GG83922@cell.sick.ru>
User-Agent: Mutt/1.4.2.1i
Cc: arch@FreeBSD.org, re@FreeBSD.org
Subject: Re: review: patch to restore VLAN kernel API in RELENG_6
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussion related to FreeBSD architecture <freebsd-arch.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 13 Jan 2006 17:52:12 -0000

On Fri, Jan 13, 2006 at 08:20:49PM +0300, Gleb Smirnoff wrote:
> On Fri, Jan 13, 2006 at 05:17:59PM +0000, Xin LI wrote:
> X> > +++ sys/dev/bge/if_bge.c	13 Jan 2006 17:04:31 -0000
> X> > @@ -2862,7 +2862,7 @@
> X> >  		 * attach that information to the packet.
> X> >  		 */
> X> >  		if (have_tag) {
> X> > -			VLAN_INPUT_TAG(ifp, m, vlan_tag);
> X> > +			VLAN_INPUT_TAG_NEW(ifp, m, vlan_tag);
> X> 
> X> What if "VLAN_INPUT_TAG_2" or something with numerical name?
> X> 
> X> Just my $0.02, though :-)
> 
> I really don't care. :)

Heh, my point was to make it possible to use the same name in
both drivers on RELENG_6 and 7.0, without having to call future
macros "foo_NEW_NG" or so =-)  Not really sure whether it is
conform to our tradition naming, though...

Cheers,