From owner-p4-projects@FreeBSD.ORG  Thu Dec  7 17:51:39 2006
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 4894016A50A; Thu,  7 Dec 2006 17:51:39 +0000 (UTC)
X-Original-To: perforce@FreeBSD.org
Delivered-To: perforce@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 1206716A403;
	Thu,  7 Dec 2006 17:51:39 +0000 (UTC)
	(envelope-from flag@newluxor.wired.org)
Received: from mail.oltrelinux.com (krisma.oltrelinux.com [194.242.226.43])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 10C8343D8D;
	Thu,  7 Dec 2006 17:48:43 +0000 (GMT)
	(envelope-from flag@newluxor.wired.org)
Received: from newluxor.wired.org (ip-64-88.sn2.eutelia.it [83.211.64.88])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mail.oltrelinux.com (Postfix) with ESMTP id 7096811AE56;
	Thu,  7 Dec 2006 18:49:22 +0100 (CET)
Received: (from flag@localhost)
	by newluxor.wired.org (8.13.8/8.13.8/Submit) id kB7HnIE9002952;
	Thu, 7 Dec 2006 18:49:18 +0100 (CET) (envelope-from flag)
Date: Thu, 7 Dec 2006 18:49:13 +0100
From: Paolo Pisati <piso@FreeBSD.org>
To: Robert Watson <rwatson@FreeBSD.org>
Message-ID: <20061207174913.GB1195@tin.it>
References: <200612062319.kB6NJgsq031755@repoman.freebsd.org>
	<20061207110225.GU32700@FreeBSD.org>
	<4578070A.2030609@freebsd.org> <20061207142254.GA1195@tin.it>
	<20061207161434.O50906@fledge.watson.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20061207161434.O50906@fledge.watson.org>
User-Agent: Mutt/1.4.2.2i
X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at krisma.oltrelinux.com
Cc: Perforce Change Reviews <perforce@FreeBSD.org>,
	Gleb Smirnoff <glebius@FreeBSD.org>, Andre Oppermann <andre@FreeBSD.org>,
	Paolo Pisati <piso@FreeBSD.org>
Subject: Re: PERFORCE change 111230 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 07 Dec 2006 17:51:39 -0000

On Thu, Dec 07, 2006 at 04:16:41PM +0000, Robert Watson wrote:
> On Thu, 7 Dec 2006, Paolo Pisati wrote:
> 
> >Then, after a discussion on irc, pull the plug on any present (and future) 
> >hackery & half-baked solution, and declare in kernel libalias incompatible 
> >with tso.
> 
> This seems silly -- why is it not compatible? 

Because libalias expects a pkt into a contiguous piece of memory, and
to achieve this we previously do a pullup of the entire pkt into an
mbuf cluster. This worked fine until libalias met a tso capable nic,
and i did a 'cvsup' on that box: TSO created pkts bigger than 2k, the
pullup function couldn't handle them and pkts were silently discarded.

The real solution here is to make libalias use mbuf chain, but i
wanted this code to enter the tree without any further delay, and thus
libalias was declared incompatible with tso.


bye
-- 

Paolo

Piso's first law: nothing works as expected!