From owner-freebsd-net@freebsd.org  Thu Dec 17 22:16:10 2015
Return-Path: <owner-freebsd-net@freebsd.org>
Delivered-To: freebsd-net@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0D21FA4A900
 for <freebsd-net@mailman.ysv.freebsd.org>;
 Thu, 17 Dec 2015 22:16:10 +0000 (UTC)
 (envelope-from daemon-user@freebsd.org)
Received: from phabric-backend.rbsd.freebsd.org (unknown
 [IPv6:2607:fc50:2000:101::1bb:73])
 by mx1.freebsd.org (Postfix) with ESMTP id EE8B7135B
 for <freebsd-net@freebsd.org>; Thu, 17 Dec 2015 22:16:09 +0000 (UTC)
 (envelope-from daemon-user@freebsd.org)
Received: by phabric-backend.rbsd.freebsd.org (Postfix, from userid 1346)
 id ED16811EBD; Thu, 17 Dec 2015 22:16:09 +0000 (UTC)
Date: Thu, 17 Dec 2015 22:16:09 +0000
To: freebsd-net@freebsd.org
From: "melifaro (Alexander V. Chernikov)" <phabric-noreply@FreeBSD.org>
Reply-to: D1986+325+381818416dc12ca2@reviews.freebsd.org
Subject: [Differential] [Commented On] D1986: Teach lagg(4) to change MTU
Message-ID: <e7e91eba1ede1b1abb33a7b453a06ee0@localhost.localdomain>
X-Priority: 3
X-Phabricator-Sent-This-Message: Yes
X-Mail-Transport-Agent: MetaMTA
X-Auto-Response-Suppress: All
X-Phabricator-Mail-Tags: <differential-comment>
Thread-Topic: D1986: Teach lagg(4) to change MTU
X-Herald-Rules: none, <28>
X-Phabricator-To: <PHID-USER-pbjjrvopgkyak7vfg3b2>
X-Phabricator-To: <PHID-USER-vtlauz4uwe46gac4fu2j>
X-Phabricator-To: <PHID-USER-gxjszcyr3icxaytfydyu>
X-Phabricator-Cc: <PHID-USER-wqysm6qikfri2awpdmpj>
X-Phabricator-Cc: <PHID-USER-q5lmute3rwskeizvu5gf>
X-Phabricator-Cc: <PHID-USER-d7hlhjvonwbh6sezyfcn>
X-Phabricator-Cc: <PHID-USER-jfdfp3ujmysz623mloir>
X-Phabricator-Cc: <PHID-USER-u62wa6uhdoiyjmodxchd>
X-Phabricator-Cc: <PHID-USER-m472qpdkxj722xbzguun>
X-Phabricator-Cc: <PHID-USER-axkijn4pfdxlezgbnt7g>
X-Phabricator-Cc: <PHID-USER-e73re76ob52gi4vjprnd>
X-Phabricator-Cc: <PHID-USER-dyyyzfp34mimhzvg33tk>
Precedence: bulk
In-Reply-To: <differential-rev-PHID-DREV-i34kfg4qpajia7fo5u5l-req@FreeBSD.org>
References: <differential-rev-PHID-DREV-i34kfg4qpajia7fo5u5l-req@FreeBSD.org>
Thread-Index: ODZhMzNlYThiYzMxOTgzYmRhMDE5M2Q2Yzk4IFZzNCk=
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="utf-8"
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.20
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net/>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 17 Dec 2015 22:16:10 -0000

melifaro added inline comments.

INLINE COMMENTS
  sys/net/if_lagg.c:728 What if we have multiple events queued on tasq? e.g mtu AND mac change
  sys/net/if_lagg.c:763 Not that easy, unfortunately.
  At this moment original ioctl returned 0, so other things/events were fired:
  rtsock notification, IPv6 nd mtg update, route table mtg update.. see net/if.c for more details.
  Trying to silently revert part of it without dealing with other things is not a good idea.

REPOSITORY
  rS FreeBSD src repository

REVISION DETAIL
  https://reviews.freebsd.org/D1986

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: rpokala, rstone, rpokala-panasas.com
Cc: smh, imp, melifaro, hrs, sbruno, lakshmi.n_msystechnologies.com, emaste, ae, freebsd-net-list