From owner-freebsd-fs@FreeBSD.ORG Mon Mar 5 05:27:14 2007 Return-Path: X-Original-To: freebsd-fs@FreeBSD.org Delivered-To: freebsd-fs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 1DFD416A404 for ; Mon, 5 Mar 2007 05:27:14 +0000 (UTC) (envelope-from ota@j.email.ne.jp) Received: from mail.asahi-net.or.jp (mail1.asahi-net.or.jp [202.224.39.197]) by mx1.freebsd.org (Postfix) with ESMTP id D462B13C491 for ; Mon, 5 Mar 2007 05:27:13 +0000 (UTC) (envelope-from ota@j.email.ne.jp) Received: from dynabook-freebsd.advok.com (pool-141-152-254-63.phlapa.east.verizon.net [141.152.254.63]) by mail.asahi-net.or.jp (Postfix) with ESMTP id C4F9832AE3; Mon, 5 Mar 2007 14:06:10 +0900 (JST) Date: Mon, 5 Mar 2007 00:05:27 -0500 From: Yoshihiro Ota To: freebsd-fs@FreeBSD.org Message-Id: <20070305000527.b507543e.ota@j.email.ne.jp> In-Reply-To: <20070304123801.GA22350@garage.freebsd.pl> References: <20070304123801.GA22350@garage.freebsd.pl> X-Mailer: Sylpheed version 2.2.9 (GTK+ 2.10.9; i386-portbld-freebsd7.0) Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="Multipart=_Mon__5_Mar_2007_00_05_27_-0500_xArzdqEbLKMaymZJ" Cc: freebsd-current@FreeBSD.org, Pawel Jakub Dawidek Subject: Re: ZFS port to FreeBSD: 2nd patchset available. X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Mar 2007 05:27:14 -0000 This is a multi-part message in MIME format. --Multipart=_Mon__5_Mar_2007_00_05_27_-0500_xArzdqEbLKMaymZJ Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sun, 4 Mar 2007 13:38:01 +0100 Pawel Jakub Dawidek wrote: > Please report any problems ('it works without problems!' is nice too). > > Good luck. I just started trying the 1st patchset about a week ago. There is no reason why not to try the 2nd patchset. Well, here is how I did it. 1. Since I had the 1st patch sets, void it first via reverse patch. % patch -R -p0 < zfs_20061117.patch 2. There were some conflict/failure; I deleted them. % rm files-that-reverse-patch-failed 3. Update source tree to recover deleted files. % cvs up 4. Apply the 2nd patchset. % patch -p0 < zfs_20070303.patch 5. I somehow got compile error so that I needed to fix it. % patch -p0 < zfs-patchset2-fix.diff atomic_cas_ptr returns (void*) and winner is (dnode_t *). For some reason, the compiler complained and I needed to cast. "make kernel" was successful and I rebooted and verified that I could load zfs module. And then, I ran out of time; I will try it again later. Thank you for your hard work. Regards, Hiro --Multipart=_Mon__5_Mar_2007_00_05_27_-0500_xArzdqEbLKMaymZJ Content-Type: text/plain; name="zfs-patchset2-fix.diff" Content-Disposition: attachment; filename="zfs-patchset2-fix.diff" Content-Transfer-Encoding: 7bit --- sys/contrib/opensolaris/uts/common/fs/zfs/dnode.c.orig2 Sun Mar 4 23:09:11 2007 +++ sys/contrib/opensolaris/uts/common/fs/zfs/dnode.c Sun Mar 4 23:09:32 2007 @@ -605,7 +605,7 @@ dnode_t *winner; dn = dnode_create(os, (dnode_phys_t *)db->db.db_data+idx, db, object); - winner = atomic_cas_ptr(&children_dnodes[idx], NULL, dn); + winner = (dnode_t*)atomic_cas_ptr(&children_dnodes[idx], NULL, dn); if (winner != NULL) { dnode_destroy(dn); dn = winner; --Multipart=_Mon__5_Mar_2007_00_05_27_-0500_xArzdqEbLKMaymZJ--