From owner-cvs-all Wed Apr 3 6:19:52 2002 Delivered-To: cvs-all@freebsd.org Received: from mailhub.yumyumyum.org (dsl092-171-091.wdc1.dsl.speakeasy.net [66.92.171.91]) by hub.freebsd.org (Postfix) with SMTP id 5CEFB37B41A for ; Wed, 3 Apr 2002 06:19:45 -0800 (PST) Received: (qmail 52980 invoked from network); 3 Apr 2002 14:19:06 -0000 Received: from ken.yumyumyum.org (192.168.0.2) by router.yumyumyum.org with SMTP; 3 Apr 2002 14:19:06 -0000 Content-Type: text/plain; charset="iso-8859-1" From: Kenneth Culver To: Alexey Dokuchaev Subject: Re: cvs commit: src/sys/i386/i386 critical.c src/sys/i386/include cpufunc.h critical.h src/sys/i386/isa apic_vector.s icu_vector.s src/sys/kern kern_fork.c kern_proc.c kern_switch.c src/sys/alpha/alph Date: Wed, 3 Apr 2002 09:20:19 -0500 X-Mailer: KMail [version 1.4] References: <20020402100957.C45652-100000@alpha.yumyumyum.org> <20020403145619.A31477@regency.nsu.ru> In-Reply-To: <20020403145619.A31477@regency.nsu.ru> Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-Id: <200204030920.19895.culverk@yumyumyum.org> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Wednesday 03 April 2002 02:56 am, Alexey Dokuchaev wrote: > On Tue, Apr 02, 2002 at 11:22:53AM -0800, Julian Elischer wrote: > > On Tue, 2 Apr 2002, Kenneth Culver wrote: > > > > > =09if (a) { > > > > > =09 x; > > > > > =09 y; > > > > > =09} else > > > > > =09 /* > > > > > =09 * HITHERE! > > > > > =09 */ > > > > > =09 b; > > > > > > > > This looks better with proper 8 character tabs. I think in KNF e= xtra > > > > braces are normally used in situations like this, but this is an = edge > > > > case. > > > > > > 8 character tabs? why use tabs at all? That requires an > > > engineer/programmer to set that in an editor, and a lot of people d= on't > > > like having tabs that are that large... I just use spaces because t= hen > > > my code will look the same as when I wrote it no matter what editor= is > > > used, and no matter what the tabs are set to. > > > > Then your code would be different from all other code in FreeBSD. > > Code checeked in should be 8 character tabs.. this is one of the most > > BASIC requirements, even if some developers feel themselves too impor= tant > > to abide by it.. It is one of the first things that gives the BSD > > code base a unified appearance. > > I totally agree: from what I've seen, faaaar most of BSD code looks so > unified (read: neat and appealing), contrary to Linux' one, for instanc= e > ;-) > > Methinks it's very inappropriate to destroy that style(9) tradition of > years... Not really what I was suggesting, Just suggesting that people use 8 space= s=20 instead of tabs, but I see why this is a bad idea too... mainly for disk=20 space (and it "destroys style(9) tradition" :-) ) Ken > > ./danfe > > To Unsubscribe: send mail to majordomo@FreeBSD.org > with "unsubscribe cvs-all" in the body of the message To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message